From: akpm@linux-foundation.org
To: mm-commits@vger.kernel.org
Cc: segooon@gmail.com, dougthompson@xmission.com,
jroberson@jroberson.net, mchehab@redhat.com
Subject: + edac-i5000-improve-handling-of-pci_enable_device-return-value.patch added to -mm tree
Date: Fri, 23 Jul 2010 14:44:54 -0700 [thread overview]
Message-ID: <201007232144.o6NLitrT009904@imap1.linux-foundation.org> (raw)
The patch titled
edac: i5000: improve handling of pci_enable_device() return value
has been added to the -mm tree. Its filename is
edac-i5000-improve-handling-of-pci_enable_device-return-value.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/SubmitChecklist when testing your code ***
See http://userweb.kernel.org/~akpm/stuff/added-to-mm.txt to find
out what to do about this
The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/
------------------------------------------------------
Subject: edac: i5000: improve handling of pci_enable_device() return value
From: Kulikov Vasiliy <segooon@gmail.com>
-EIO is not the only error code that pci_enable_device() may return, also
the set of errors can be enhanced in future. We should compare return
code with zero, not with concrete error value.
Signed-off-by: Kulikov Vasiliy <segooon@gmail.com>
Cc: Mauro Carvalho Chehab <mchehab@redhat.com>
Cc: Jeff Roberson <jroberson@jroberson.net>
Cc: Doug Thompson <dougthompson@xmission.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
drivers/edac/i5000_edac.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff -puN drivers/edac/i5000_edac.c~edac-i5000-improve-handling-of-pci_enable_device-return-value drivers/edac/i5000_edac.c
--- a/drivers/edac/i5000_edac.c~edac-i5000-improve-handling-of-pci_enable_device-return-value
+++ a/drivers/edac/i5000_edac.c
@@ -1482,7 +1482,7 @@ static int __devinit i5000_init_one(stru
/* wake up device */
rc = pci_enable_device(pdev);
- if (rc == -EIO)
+ if (rc)
return rc;
/* now probe and enable the device */
_
Patches currently in -mm which might be from segooon@gmail.com are
linux-next.patch
i2o-fix-overflow-of-copy_to_user.patch
i2o-check-return-code-from-put_user.patch
edac-i5000-improve-handling-of-pci_enable_device-return-value.patch
edac-i5400-improve-handling-of-pci_enable_device-return-value.patch
reply other threads:[~2010-07-23 21:45 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201007232144.o6NLitrT009904@imap1.linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=dougthompson@xmission.com \
--cc=jroberson@jroberson.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@redhat.com \
--cc=mm-commits@vger.kernel.org \
--cc=segooon@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox