Linux MM tree latest commits
 help / color / mirror / Atom feed
* + edac-i5000-improve-handling-of-pci_enable_device-return-value.patch added to -mm tree
@ 2010-07-23 21:44 akpm
  0 siblings, 0 replies; only message in thread
From: akpm @ 2010-07-23 21:44 UTC (permalink / raw)
  To: mm-commits; +Cc: segooon, dougthompson, jroberson, mchehab


The patch titled
     edac: i5000: improve handling of pci_enable_device() return value
has been added to the -mm tree.  Its filename is
     edac-i5000-improve-handling-of-pci_enable_device-return-value.patch

Before you just go and hit "reply", please:
   a) Consider who else should be cc'ed
   b) Prefer to cc a suitable mailing list as well
   c) Ideally: find the original patch on the mailing list and do a
      reply-to-all to that, adding suitable additional cc's

*** Remember to use Documentation/SubmitChecklist when testing your code ***

See http://userweb.kernel.org/~akpm/stuff/added-to-mm.txt to find
out what to do about this

The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/

------------------------------------------------------
Subject: edac: i5000: improve handling of pci_enable_device() return value
From: Kulikov Vasiliy <segooon@gmail.com>

-EIO is not the only error code that pci_enable_device() may return, also
the set of errors can be enhanced in future.  We should compare return
code with zero, not with concrete error value.

Signed-off-by: Kulikov Vasiliy <segooon@gmail.com>
Cc: Mauro Carvalho Chehab <mchehab@redhat.com>
Cc: Jeff Roberson <jroberson@jroberson.net>
Cc: Doug Thompson <dougthompson@xmission.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 drivers/edac/i5000_edac.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff -puN drivers/edac/i5000_edac.c~edac-i5000-improve-handling-of-pci_enable_device-return-value drivers/edac/i5000_edac.c
--- a/drivers/edac/i5000_edac.c~edac-i5000-improve-handling-of-pci_enable_device-return-value
+++ a/drivers/edac/i5000_edac.c
@@ -1482,7 +1482,7 @@ static int __devinit i5000_init_one(stru
 
 	/* wake up device */
 	rc = pci_enable_device(pdev);
-	if (rc == -EIO)
+	if (rc)
 		return rc;
 
 	/* now probe and enable the device */
_

Patches currently in -mm which might be from segooon@gmail.com are

linux-next.patch
i2o-fix-overflow-of-copy_to_user.patch
i2o-check-return-code-from-put_user.patch
edac-i5000-improve-handling-of-pci_enable_device-return-value.patch
edac-i5400-improve-handling-of-pci_enable_device-return-value.patch


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2010-07-23 21:45 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-07-23 21:44 + edac-i5000-improve-handling-of-pci_enable_device-return-value.patch added to -mm tree akpm

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox