* + mm-hugetlb-suppress-wrong-warning-info-when-alloc-gigantic-page.patch added to -mm tree
@ 2021-02-19 23:19 akpm
0 siblings, 0 replies; 6+ messages in thread
From: akpm @ 2021-02-19 23:19 UTC (permalink / raw)
To: mm-commits, mike.kravetz, guro, chenwandun
The patch titled
Subject: mm/hugetlb: suppress wrong warning info when alloc gigantic page
has been added to the -mm tree. Its filename is
mm-hugetlb-suppress-wrong-warning-info-when-alloc-gigantic-page.patch
This patch should soon appear at
https://ozlabs.org/~akpm/mmots/broken-out/mm-hugetlb-suppress-wrong-warning-info-when-alloc-gigantic-page.patch
and later at
https://ozlabs.org/~akpm/mmotm/broken-out/mm-hugetlb-suppress-wrong-warning-info-when-alloc-gigantic-page.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/process/submit-checklist.rst when testing your code ***
The -mm tree is included into linux-next and is updated
there every 3-4 working days
------------------------------------------------------
From: Chen Wandun <chenwandun@huawei.com>
Subject: mm/hugetlb: suppress wrong warning info when alloc gigantic page
If hugetlb_cma is enabled, it will skip boot time allocation when
allocating gigantic page, that doesn't means allocation failure, so
suppress this warning info.
Link: https://lkml.kernel.org/r/20210219123909.13130-1-chenwandun@huawei.com
Fixes: cf11e85fc08c ("mm: hugetlb: optionally allocate gigantic hugepages using cma")
Signed-off-by: Chen Wandun <chenwandun@huawei.com>
Reviewed-by: Mike Kravetz <mike.kravetz@oracle.com>
Cc: Roman Gushchin <guro@fb.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
mm/hugetlb.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--- a/mm/hugetlb.c~mm-hugetlb-suppress-wrong-warning-info-when-alloc-gigantic-page
+++ a/mm/hugetlb.c
@@ -2529,7 +2529,7 @@ static void __init hugetlb_hstate_alloc_
if (hstate_is_gigantic(h)) {
if (hugetlb_cma_size) {
pr_warn_once("HugeTLB: hugetlb_cma is enabled, skip boot time allocation\n");
- break;
+ goto free;
}
if (!alloc_bootmem_huge_page(h))
break;
@@ -2547,7 +2547,7 @@ static void __init hugetlb_hstate_alloc_
h->max_huge_pages, buf, i);
h->max_huge_pages = i;
}
-
+free:
kfree(node_alloc_noretry);
}
_
Patches currently in -mm which might be from chenwandun@huawei.com are
mm-hugetlb-suppress-wrong-warning-info-when-alloc-gigantic-page.patch
^ permalink raw reply [flat|nested] 6+ messages in thread* + mm-hugetlb-suppress-wrong-warning-info-when-alloc-gigantic-page.patch added to -mm tree
@ 2021-02-19 18:37 akpm
2021-02-19 19:47 ` Roman Gushchin
0 siblings, 1 reply; 6+ messages in thread
From: akpm @ 2021-02-19 18:37 UTC (permalink / raw)
To: mm-commits, mike.kravetz, guro, chenwandun
The patch titled
Subject: mm/hugetlb: suppress wrong warning info when alloc gigantic page
has been added to the -mm tree. Its filename is
mm-hugetlb-suppress-wrong-warning-info-when-alloc-gigantic-page.patch
This patch should soon appear at
https://ozlabs.org/~akpm/mmots/broken-out/mm-hugetlb-suppress-wrong-warning-info-when-alloc-gigantic-page.patch
and later at
https://ozlabs.org/~akpm/mmotm/broken-out/mm-hugetlb-suppress-wrong-warning-info-when-alloc-gigantic-page.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/process/submit-checklist.rst when testing your code ***
The -mm tree is included into linux-next and is updated
there every 3-4 working days
------------------------------------------------------
From: Chen Wandun <chenwandun@huawei.com>
Subject: mm/hugetlb: suppress wrong warning info when alloc gigantic page
If hugetlb_cma is enabled, it will skip boot time allocation when
allocating gigantic page, that doesn't means allocation failure, so
suppress this warning info.
Link: https://lkml.kernel.org/r/20210219123909.13130-1-chenwandun@huawei.com
Fixes: cf11e85fc08c ("mm: hugetlb: optionally allocate gigantic hugepages using cma")
Signed-off-by: Chen Wandun <chenwandun@huawei.com>
Cc: Roman Gushchin <guro@fb.com>
Cc: Mike Kravetz <mike.kravetz@oracle.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
mm/hugetlb.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--- a/mm/hugetlb.c~mm-hugetlb-suppress-wrong-warning-info-when-alloc-gigantic-page
+++ a/mm/hugetlb.c
@@ -2529,7 +2529,7 @@ static void __init hugetlb_hstate_alloc_
if (hstate_is_gigantic(h)) {
if (hugetlb_cma_size) {
pr_warn_once("HugeTLB: hugetlb_cma is enabled, skip boot time allocation\n");
- break;
+ goto free;
}
if (!alloc_bootmem_huge_page(h))
break;
@@ -2547,7 +2547,7 @@ static void __init hugetlb_hstate_alloc_
h->max_huge_pages, buf, i);
h->max_huge_pages = i;
}
-
+free:
kfree(node_alloc_noretry);
}
_
Patches currently in -mm which might be from chenwandun@huawei.com are
mm-hugetlb-suppress-wrong-warning-info-when-alloc-gigantic-page.patch
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: + mm-hugetlb-suppress-wrong-warning-info-when-alloc-gigantic-page.patch added to -mm tree
2021-02-19 18:37 akpm
@ 2021-02-19 19:47 ` Roman Gushchin
2021-02-19 20:04 ` Mike Kravetz
0 siblings, 1 reply; 6+ messages in thread
From: Roman Gushchin @ 2021-02-19 19:47 UTC (permalink / raw)
To: akpm; +Cc: mm-commits, mike.kravetz, chenwandun
On Fri, Feb 19, 2021 at 10:37:17AM -0800, Andrew Morton wrote:
>
> The patch titled
> Subject: mm/hugetlb: suppress wrong warning info when alloc gigantic page
> has been added to the -mm tree. Its filename is
> mm-hugetlb-suppress-wrong-warning-info-when-alloc-gigantic-page.patch
>
> This patch should soon appear at
> https://ozlabs.org/~akpm/mmots/broken-out/mm-hugetlb-suppress-wrong-warning-info-when-alloc-gigantic-page.patch
> and later at
> https://ozlabs.org/~akpm/mmotm/broken-out/mm-hugetlb-suppress-wrong-warning-info-when-alloc-gigantic-page.patch
>
> Before you just go and hit "reply", please:
> a) Consider who else should be cc'ed
> b) Prefer to cc a suitable mailing list as well
> c) Ideally: find the original patch on the mailing list and do a
> reply-to-all to that, adding suitable additional cc's
>
> *** Remember to use Documentation/process/submit-checklist.rst when testing your code ***
>
> The -mm tree is included into linux-next and is updated
> there every 3-4 working days
>
> ------------------------------------------------------
> From: Chen Wandun <chenwandun@huawei.com>
> Subject: mm/hugetlb: suppress wrong warning info when alloc gigantic page
>
> If hugetlb_cma is enabled, it will skip boot time allocation when
> allocating gigantic page, that doesn't means allocation failure, so
> suppress this warning info.
>
> Link: https://lkml.kernel.org/r/20210219123909.13130-1-chenwandun@huawei.com
> Fixes: cf11e85fc08c ("mm: hugetlb: optionally allocate gigantic hugepages using cma")
> Signed-off-by: Chen Wandun <chenwandun@huawei.com>
> Cc: Roman Gushchin <guro@fb.com>
> Cc: Mike Kravetz <mike.kravetz@oracle.com>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Acked-by: Roman Gushchin <guro@fb.com>
Thanks!
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: + mm-hugetlb-suppress-wrong-warning-info-when-alloc-gigantic-page.patch added to -mm tree
2021-02-19 19:47 ` Roman Gushchin
@ 2021-02-19 20:04 ` Mike Kravetz
2021-02-19 20:11 ` Roman Gushchin
0 siblings, 1 reply; 6+ messages in thread
From: Mike Kravetz @ 2021-02-19 20:04 UTC (permalink / raw)
To: Roman Gushchin, akpm; +Cc: mm-commits, chenwandun
On 2/19/21 11:47 AM, Roman Gushchin wrote:
> On Fri, Feb 19, 2021 at 10:37:17AM -0800, Andrew Morton wrote:
>>
>> The patch titled
>> Subject: mm/hugetlb: suppress wrong warning info when alloc gigantic page
>> has been added to the -mm tree. Its filename is
>> mm-hugetlb-suppress-wrong-warning-info-when-alloc-gigantic-page.patch
>>
>> This patch should soon appear at
>> https://ozlabs.org/~akpm/mmots/broken-out/mm-hugetlb-suppress-wrong-warning-info-when-alloc-gigantic-page.patch
>> and later at
>> https://ozlabs.org/~akpm/mmotm/broken-out/mm-hugetlb-suppress-wrong-warning-info-when-alloc-gigantic-page.patch
>>
>> Before you just go and hit "reply", please:
>> a) Consider who else should be cc'ed
>> b) Prefer to cc a suitable mailing list as well
>> c) Ideally: find the original patch on the mailing list and do a
>> reply-to-all to that, adding suitable additional cc's
>>
>> *** Remember to use Documentation/process/submit-checklist.rst when testing your code ***
>>
>> The -mm tree is included into linux-next and is updated
>> there every 3-4 working days
>>
>> ------------------------------------------------------
>> From: Chen Wandun <chenwandun@huawei.com>
>> Subject: mm/hugetlb: suppress wrong warning info when alloc gigantic page
>>
>> If hugetlb_cma is enabled, it will skip boot time allocation when
>> allocating gigantic page, that doesn't means allocation failure, so
>> suppress this warning info.
>>
>> Link: https://lkml.kernel.org/r/20210219123909.13130-1-chenwandun@huawei.com
>> Fixes: cf11e85fc08c ("mm: hugetlb: optionally allocate gigantic hugepages using cma")
>> Signed-off-by: Chen Wandun <chenwandun@huawei.com>
>> Cc: Roman Gushchin <guro@fb.com>
>> Cc: Mike Kravetz <mike.kravetz@oracle.com>
>> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
>
> Acked-by: Roman Gushchin <guro@fb.com>
>
> Thanks!
Roman, I was under the impression that this warning provided some value?
It will only be logged if user asks for both preallocation and cma reservation
on the command line. In this case, we ignore the parameter requesting
preallocation. It seems reasonable that we log a warning if dropping a
user requested parameter.
--
Mike Kravetz
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: + mm-hugetlb-suppress-wrong-warning-info-when-alloc-gigantic-page.patch added to -mm tree
2021-02-19 20:04 ` Mike Kravetz
@ 2021-02-19 20:11 ` Roman Gushchin
2021-02-19 21:19 ` Mike Kravetz
0 siblings, 1 reply; 6+ messages in thread
From: Roman Gushchin @ 2021-02-19 20:11 UTC (permalink / raw)
To: Mike Kravetz; +Cc: akpm, mm-commits, chenwandun
On Fri, Feb 19, 2021 at 12:04:32PM -0800, Mike Kravetz wrote:
> On 2/19/21 11:47 AM, Roman Gushchin wrote:
> > On Fri, Feb 19, 2021 at 10:37:17AM -0800, Andrew Morton wrote:
> >>
> >> The patch titled
> >> Subject: mm/hugetlb: suppress wrong warning info when alloc gigantic page
> >> has been added to the -mm tree. Its filename is
> >> mm-hugetlb-suppress-wrong-warning-info-when-alloc-gigantic-page.patch
> >>
> >> This patch should soon appear at
> >> https://ozlabs.org/~akpm/mmots/broken-out/mm-hugetlb-suppress-wrong-warning-info-when-alloc-gigantic-page.patch
> >> and later at
> >> https://ozlabs.org/~akpm/mmotm/broken-out/mm-hugetlb-suppress-wrong-warning-info-when-alloc-gigantic-page.patch
> >>
> >> Before you just go and hit "reply", please:
> >> a) Consider who else should be cc'ed
> >> b) Prefer to cc a suitable mailing list as well
> >> c) Ideally: find the original patch on the mailing list and do a
> >> reply-to-all to that, adding suitable additional cc's
> >>
> >> *** Remember to use Documentation/process/submit-checklist.rst when testing your code ***
> >>
> >> The -mm tree is included into linux-next and is updated
> >> there every 3-4 working days
> >>
> >> ------------------------------------------------------
> >> From: Chen Wandun <chenwandun@huawei.com>
> >> Subject: mm/hugetlb: suppress wrong warning info when alloc gigantic page
> >>
> >> If hugetlb_cma is enabled, it will skip boot time allocation when
> >> allocating gigantic page, that doesn't means allocation failure, so
> >> suppress this warning info.
> >>
> >> Link: https://lkml.kernel.org/r/20210219123909.13130-1-chenwandun@huawei.com
> >> Fixes: cf11e85fc08c ("mm: hugetlb: optionally allocate gigantic hugepages using cma")
> >> Signed-off-by: Chen Wandun <chenwandun@huawei.com>
> >> Cc: Roman Gushchin <guro@fb.com>
> >> Cc: Mike Kravetz <mike.kravetz@oracle.com>
> >> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> >
> > Acked-by: Roman Gushchin <guro@fb.com>
> >
> > Thank!s
>
>
> Roman, I was under the impression that this warning provided some value?
>
> It will only be logged if user asks for both preallocation and cma reservation
> on the command line. In this case, we ignore the parameter requesting
> preallocation. It seems reasonable that we log a warning if dropping a
> user requested parameter.
There are two warnings:
"HugeTLB: hugetlb_cma is enabled, skip boot time allocation\n" and
"HugeTLB: allocating %lu of page size %s failed. Only allocated %lu hugepages.\n"
The point of this patch is to skip printing the second one if the first one is printed.
It makes sense to me.
Thanks!
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: + mm-hugetlb-suppress-wrong-warning-info-when-alloc-gigantic-page.patch added to -mm tree
2021-02-19 20:11 ` Roman Gushchin
@ 2021-02-19 21:19 ` Mike Kravetz
0 siblings, 0 replies; 6+ messages in thread
From: Mike Kravetz @ 2021-02-19 21:19 UTC (permalink / raw)
To: Roman Gushchin; +Cc: akpm, mm-commits, chenwandun
On 2/19/21 12:11 PM, Roman Gushchin wrote:
> On Fri, Feb 19, 2021 at 12:04:32PM -0800, Mike Kravetz wrote:
>> On 2/19/21 11:47 AM, Roman Gushchin wrote:
>>> On Fri, Feb 19, 2021 at 10:37:17AM -0800, Andrew Morton wrote:
>>>>
>>>> The patch titled
>>>> Subject: mm/hugetlb: suppress wrong warning info when alloc gigantic page
>>>> has been added to the -mm tree. Its filename is
>>>> mm-hugetlb-suppress-wrong-warning-info-when-alloc-gigantic-page.patch
>>>>
>>>> This patch should soon appear at
>>>> https://ozlabs.org/~akpm/mmots/broken-out/mm-hugetlb-suppress-wrong-warning-info-when-alloc-gigantic-page.patch
>>>> and later at
>>>> https://ozlabs.org/~akpm/mmotm/broken-out/mm-hugetlb-suppress-wrong-warning-info-when-alloc-gigantic-page.patch
>>>>
>>>> Before you just go and hit "reply", please:
>>>> a) Consider who else should be cc'ed
>>>> b) Prefer to cc a suitable mailing list as well
>>>> c) Ideally: find the original patch on the mailing list and do a
>>>> reply-to-all to that, adding suitable additional cc's
>>>>
>>>> *** Remember to use Documentation/process/submit-checklist.rst when testing your code ***
>>>>
>>>> The -mm tree is included into linux-next and is updated
>>>> there every 3-4 working days
>>>>
>>>> ------------------------------------------------------
>>>> From: Chen Wandun <chenwandun@huawei.com>
>>>> Subject: mm/hugetlb: suppress wrong warning info when alloc gigantic page
>>>>
>>>> If hugetlb_cma is enabled, it will skip boot time allocation when
>>>> allocating gigantic page, that doesn't means allocation failure, so
>>>> suppress this warning info.
>>>>
>>>> Link: https://lkml.kernel.org/r/20210219123909.13130-1-chenwandun@huawei.com
>>>> Fixes: cf11e85fc08c ("mm: hugetlb: optionally allocate gigantic hugepages using cma")
>>>> Signed-off-by: Chen Wandun <chenwandun@huawei.com>
>>>> Cc: Roman Gushchin <guro@fb.com>
>>>> Cc: Mike Kravetz <mike.kravetz@oracle.com>
>>>> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
>>>
>>> Acked-by: Roman Gushchin <guro@fb.com>
>>>
>>> Thank!s
>>
>>
>> Roman, I was under the impression that this warning provided some value?
>>
>> It will only be logged if user asks for both preallocation and cma reservation
>> on the command line. In this case, we ignore the parameter requesting
>> preallocation. It seems reasonable that we log a warning if dropping a
>> user requested parameter.
>
> There are two warnings:
> "HugeTLB: hugetlb_cma is enabled, skip boot time allocation\n" and
> "HugeTLB: allocating %lu of page size %s failed. Only allocated %lu hugepages.\n"
>
> The point of this patch is to skip printing the second one if the first one is printed.
> It makes sense to me.
>
> Thanks!
Thanks you!
My bad for not taking a closer look.
--
Mike Kravetz
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-02-19 23:20 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-02-19 23:19 + mm-hugetlb-suppress-wrong-warning-info-when-alloc-gigantic-page.patch added to -mm tree akpm
-- strict thread matches above, loose matches on Subject: below --
2021-02-19 18:37 akpm
2021-02-19 19:47 ` Roman Gushchin
2021-02-19 20:04 ` Mike Kravetz
2021-02-19 20:11 ` Roman Gushchin
2021-02-19 21:19 ` Mike Kravetz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox