Linux MM tree latest commits
 help / color / mirror / Atom feed
* [merged] autofs-remove-ino-free-in-autofs4_dir_symlink.patch removed from -mm tree
@ 2016-10-12 19:23 akpm
  0 siblings, 0 replies; only message in thread
From: akpm @ 2016-10-12 19:23 UTC (permalink / raw)
  To: raven, kusumi.tomohiro, mm-commits


The patch titled
     Subject: autofs: remove ino free in autofs4_dir_symlink()
has been removed from the -mm tree.  Its filename was
     autofs-remove-ino-free-in-autofs4_dir_symlink.patch

This patch was dropped because it was merged into mainline or a subsystem tree

------------------------------------------------------
From: Ian Kent <raven@themaw.net>
Subject: autofs: remove ino free in autofs4_dir_symlink()

The inode allocation failure case in autofs4_dir_symlink() frees the
autofs dentry info of the dentry without setting ->d_fsdata to NULL.

That could lead to a double free so just get rid of the free and leave it
to ->d_release().

Link: http://lkml.kernel.org/r/20160812024759.12352.10653.stgit@pluto.themaw.net
Signed-off-by: Ian Kent <raven@themaw.net>
Cc: Tomohiro Kusumi <kusumi.tomohiro@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 fs/autofs4/root.c |    2 --
 1 file changed, 2 deletions(-)

diff -puN fs/autofs4/root.c~autofs-remove-ino-free-in-autofs4_dir_symlink fs/autofs4/root.c
--- a/fs/autofs4/root.c~autofs-remove-ino-free-in-autofs4_dir_symlink
+++ a/fs/autofs4/root.c
@@ -577,8 +577,6 @@ static int autofs4_dir_symlink(struct in
 	inode = autofs4_get_inode(dir->i_sb, S_IFLNK | 0555);
 	if (!inode) {
 		kfree(cp);
-		if (!dentry->d_fsdata)
-			kfree(ino);
 		return -ENOMEM;
 	}
 	inode->i_private = cp;
_

Patches currently in -mm which might be from raven@themaw.net are



^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2016-10-12 19:24 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-10-12 19:23 [merged] autofs-remove-ino-free-in-autofs4_dir_symlink.patch removed from -mm tree akpm

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox