From: Paolo Abeni <pabeni@redhat.com>
To: Gang Yan <gang.yan@linux.dev>, MPTCP Linux <mptcp@lists.linux.dev>
Cc: Gang Yan <yangang@kylinos.cn>
Subject: Re: [PATCH mptcp-next v5 4/6] mptcp: reject sockopt requiring ssks' lock in BPF context
Date: Mon, 25 May 2026 10:32:20 +0200 [thread overview]
Message-ID: <0887aa80-13c0-47eb-9178-a7f1cf9ba5e5@redhat.com> (raw)
In-Reply-To: <20260522-sockopt_lock-v5-4-108629a46e98@kylinos.cn>
On 5/22/26 11:12 AM, Gang Yan wrote:
> @@ -600,6 +609,9 @@ static int mptcp_setsockopt_sol_tcp_congestion(struct mptcp_sock *msk, sockptr_t
>
> cap_net_admin = sockopt_ns_capable(sock_net(sk)->user_ns, CAP_NET_ADMIN);
>
> + if (has_current_bpf_ctx())
> + return -EOPNOTSUPP;
I think it would be better to move the check earlier and drop the
previous patch.
Possibly it would be considered avoiding touching in patch 2 the other
functions where EBPF support is disabled here, but I have mixed feeling
WRT this later option, due to code consistency. Not a big deal either way.
/P
next prev parent reply other threads:[~2026-05-25 8:32 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-22 9:12 [PATCH mptcp-next v5 0/6] mptcp: convert to sockopt_lock_sock Gang Yan
2026-05-22 9:12 ` [PATCH mptcp-next v5 1/6] mptcp: replace lock_sock_fast with lock_sock in sockopt Gang Yan
2026-05-27 5:43 ` gang.yan
2026-05-27 9:50 ` Paolo Abeni
2026-05-22 9:12 ` [PATCH mptcp-next v5 2/6] mptcp: use sockopt_lock/release_sock " Gang Yan
2026-05-22 9:12 ` [PATCH mptcp-next v5 3/6] mptcp: use sockopt_ns_capable in congestion control Gang Yan
2026-05-22 9:12 ` [PATCH mptcp-next v5 4/6] mptcp: reject sockopt requiring ssks' lock in BPF context Gang Yan
2026-05-25 8:32 ` Paolo Abeni [this message]
2026-05-25 9:01 ` gang.yan
2026-05-27 9:53 ` Paolo Abeni
2026-05-22 9:12 ` [PATCH mptcp-next v5 5/6] DO-NOT-MERGE: mptcp: allow set some sockopt " Gang Yan
2026-05-22 9:12 ` [PATCH mptcp-next v5 6/6] DO-NOT-MERGE: selftest: bpf: set mptcp " Gang Yan
2026-05-22 10:50 ` [PATCH mptcp-next v5 0/6] mptcp: convert to sockopt_lock_sock MPTCP CI
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0887aa80-13c0-47eb-9178-a7f1cf9ba5e5@redhat.com \
--to=pabeni@redhat.com \
--cc=gang.yan@linux.dev \
--cc=mptcp@lists.linux.dev \
--cc=yangang@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox