From: Paolo Abeni <pabeni@redhat.com>
To: Gang Yan <gang.yan@linux.dev>, MPTCP Linux <mptcp@lists.linux.dev>
Cc: Gang Yan <yangang@kylinos.cn>
Subject: Re: [PATCH mptcp-next v5 1/6] mptcp: replace lock_sock_fast with lock_sock in sockopt
Date: Wed, 27 May 2026 11:50:51 +0200 [thread overview]
Message-ID: <aeb82448-8e0e-4371-b514-a0b24badc666@redhat.com> (raw)
In-Reply-To: <20260522-sockopt_lock-v5-1-108629a46e98@kylinos.cn>
On 5/22/26 11:12 AM, Gang Yan wrote:
> From: Gang Yan <yangang@kylinos.cn>
>
> Replace lock_sock_fast()/unlock_sock_fast() with lock_sock()/
> release_sock() in the MPTCP sockopt handlers to avoid accidentally
> introducing sleeping operations inside the lock_sock_fast() critical
> section.
>
> This is consistent with how other sockopt handlers in the Net code
> already use lock_sock()/release_sock().
Uhm... I went over all the chunks below and AFAICS no context can
actually sleep inside the current lock_sock_fast()/unlock_sock_fast().
The lack of pending KASAN report on that subject is also a good
indication, it should be quite doable for the tool to generate a splat
should the above statement be false.
I suggest dropping this patch.
/P
next prev parent reply other threads:[~2026-05-27 9:50 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-22 9:12 [PATCH mptcp-next v5 0/6] mptcp: convert to sockopt_lock_sock Gang Yan
2026-05-22 9:12 ` [PATCH mptcp-next v5 1/6] mptcp: replace lock_sock_fast with lock_sock in sockopt Gang Yan
2026-05-27 5:43 ` gang.yan
2026-05-27 9:50 ` Paolo Abeni [this message]
2026-05-22 9:12 ` [PATCH mptcp-next v5 2/6] mptcp: use sockopt_lock/release_sock " Gang Yan
2026-05-22 9:12 ` [PATCH mptcp-next v5 3/6] mptcp: use sockopt_ns_capable in congestion control Gang Yan
2026-05-22 9:12 ` [PATCH mptcp-next v5 4/6] mptcp: reject sockopt requiring ssks' lock in BPF context Gang Yan
2026-05-25 8:32 ` Paolo Abeni
2026-05-25 9:01 ` gang.yan
2026-05-27 9:53 ` Paolo Abeni
2026-05-22 9:12 ` [PATCH mptcp-next v5 5/6] DO-NOT-MERGE: mptcp: allow set some sockopt " Gang Yan
2026-05-22 9:12 ` [PATCH mptcp-next v5 6/6] DO-NOT-MERGE: selftest: bpf: set mptcp " Gang Yan
2026-05-22 10:50 ` [PATCH mptcp-next v5 0/6] mptcp: convert to sockopt_lock_sock MPTCP CI
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aeb82448-8e0e-4371-b514-a0b24badc666@redhat.com \
--to=pabeni@redhat.com \
--cc=gang.yan@linux.dev \
--cc=mptcp@lists.linux.dev \
--cc=yangang@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox