MPTCP Linux Development
 help / color / mirror / Atom feed
From: Geliang Tang <geliang@kernel.org>
To: Matthieu Baerts <matttbe@kernel.org>, mptcp@lists.linux.dev
Subject: Re: [PATCH mptcp-next v5 00/16] MPTCP sockmap support
Date: Mon, 14 Sep 2026 19:11:44 +0800	[thread overview]
Message-ID: <09d5ca0458d9add4c9054c246b73b785a48326c5.camel@kernel.org> (raw)
In-Reply-To: <90b59b07-8200-4990-8186-6e04844c87e4@kernel.org>

On Mon, 2026-09-14 at 12:58 +0200, Matthieu Baerts wrote:
> 
> 
> On 14/09/2026 11:48, Geliang Tang wrote:
> > Hi Matt,
> > 
> > On Sun, 2026-09-13 at 18:14 +0800, Geliang Tang wrote:
> > > From: Geliang Tang <tanggeliang@kylinos.cn>
> > > 
> > > v5:
> > >  - Patches 1-4 are from "Reduce the differences between TCP and
> > > MPTCP
> > > for TLS usage" set.
> > 
> > I put the four patches from the "Reduce the differences between TCP
> > and
> > MPTCP for TLS usage" series here because this "MPTCP sockmap
> > support"
> > series depends on them. Actually, it doesn't just depend on these
> > four
> > patches - it also appears to depend on "mptcp: remove CB offset
> > field"
> > (see sashiko's comments on patch 9) and "mptcp: implement peek_len
> > for
> > proto_ops" (see sashiko's comments on patch 13).
> > 
> > So this series depends on the entire "Reduce the differences
> > between
> > TCP and MPTCP for TLS usage" series. I could use "Based-on: <...>"
> > to
> > trigger CI based on the dependency, but Sashiko doesn't recognize
> > "Based-on", so it won't be able to apply successfully.
> > 
> > Is there some Sashiko feature that can handle this kind of chained
> > dependency between patchsets?
> 
> Not yet, apparently:
> 
>   https://github.com/sashiko-dev/sashiko/issues/49
> 
> > Or do I need to include all ten patches
> > of the "Reduce the differences between TCP and MPTCP for TLS usage"
> > series in the next version? I'd appreciate your thoughts on this.
> > 
> > Alternatively, let's first do the review of the "Reduce the
> > differences
> > between TCP and MPTCP for TLS usage" series - it's already ready
> > for
> > review - so that both the subsequent "MPTCP KTLS support" series
> > and
> > this "MPTCP sockmap support" series can move forward more easily.
> Probably best to do that. I admit that with all the different series
> and
> revisions, I'm sorry, but I'm a bit lost regarding the priorities.
> What
> should be reviewed first?
> 
> These series?
> 
>  - Reduce the differences between TCP and MPTCP for TLS usage
>  - mptcp: remove CB offset field
>  - mptcp: implement peek_len for proto_ops

Sorry for not being clear. The "Reduce the differences between TCP and
MPTCP for TLS usage" v13 [1] series needs to be reviewed - it includes
patch 3 "mptcp: remove CB offset field" and patch 7 "mptcp: implement
peek_len for proto_ops".

Thanks,
-Geliang

[1]
https://patchwork.kernel.org/project/mptcp/cover/cover.1788245079.git.tanggeliang@kylinos.cn/

> 
> Cheers,
> Matt

      reply	other threads:[~2026-09-14 11:11 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-13 10:14 [PATCH mptcp-next v5 00/16] MPTCP sockmap support Geliang Tang
2026-09-13 10:14 ` [PATCH mptcp-next v5 01/16] mptcp: defer read_sock cleanup to mptcp_worker Geliang Tang
2026-09-13 10:14 ` [PATCH mptcp-next v5 02/16] mptcp: add sendmsg_locked to proto_ops Geliang Tang
2026-09-13 10:14 ` [PATCH mptcp-next v5 03/16] mptcp: track app-limited state in mptcp_sendmsg Geliang Tang
2026-09-13 10:14 ` [PATCH mptcp-next v5 04/16] selftests: mptcp: sockopt: check app_limited Geliang Tang
2026-09-13 10:14 ` [PATCH mptcp-next v5 05/16] bpf: drop duplicate check_app_limited in tcp_bpf_push Geliang Tang
2026-09-13 18:18   ` Matthieu Baerts
2026-09-14  9:24     ` Geliang Tang
2026-09-13 10:14 ` [PATCH mptcp-next v5 06/16] mptcp: implement psock_update_sk_prot for sockmap Geliang Tang
2026-09-13 10:46   ` sashiko-bot
2026-09-13 18:22   ` Matthieu Baerts
2026-09-14  9:25     ` Geliang Tang
2026-09-13 10:14 ` [PATCH mptcp-next v5 07/16] mptcp: add sock_map_update BPF helper Geliang Tang
2026-09-13 10:30   ` sashiko-bot
2026-09-13 10:14 ` [PATCH mptcp-next v5 08/16] selftests/bpf: enable MPTCP support in sockmap tests Geliang Tang
2026-09-13 10:33   ` sashiko-bot
2026-09-13 10:14 ` [PATCH mptcp-next v5 09/16] mptcp: implement read_skb for sockmap stream verdict Geliang Tang
2026-09-13 10:40   ` sashiko-bot
2026-09-13 10:14 ` [PATCH mptcp-next v5 10/16] bpf: export and generalize tcp_bpf_ioctl Geliang Tang
2026-09-13 10:28   ` sashiko-bot
2026-09-13 10:14 ` [PATCH mptcp-next v5 11/16] mptcp: add TCP_REPAIR sockopt support Geliang Tang
2026-09-13 10:38   ` sashiko-bot
2026-09-14 10:33   ` Matthieu Baerts
2026-09-14 10:39     ` Geliang Tang
2026-09-13 10:14 ` [PATCH mptcp-next v5 12/16] selftests/bpf: add MPTCP coverage to sockmap_basic Geliang Tang
2026-09-13 10:30   ` sashiko-bot
2026-09-13 10:14 ` [PATCH mptcp-next v5 13/16] mptcp: add sk_is_msk() helper and use it in sockmap Geliang Tang
2026-09-13 10:48   ` sashiko-bot
2026-09-13 10:14 ` [PATCH mptcp-next v5 14/16] mptcp: add SO_ATTACH_REUSEPORT_EBPF support Geliang Tang
2026-09-13 10:14 ` [PATCH mptcp-next v5 15/16] mptcp: add sk_select_reuseport BPF helper Geliang Tang
2026-09-13 10:48   ` sashiko-bot
2026-09-13 10:14 ` [PATCH mptcp-next v5 16/16] selftests/bpf: add MPTCP coverage to sockmap_listen Geliang Tang
2026-09-13 10:45   ` sashiko-bot
2026-09-13 11:24 ` [PATCH mptcp-next v5 00/16] MPTCP sockmap support MPTCP CI
2026-09-13 11:43 ` MPTCP CI
2026-09-14  9:48 ` Geliang Tang
2026-09-14 10:58   ` Matthieu Baerts
2026-09-14 11:11     ` Geliang Tang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=09d5ca0458d9add4c9054c246b73b785a48326c5.camel@kernel.org \
    --to=geliang@kernel.org \
    --cc=matttbe@kernel.org \
    --cc=mptcp@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox