Re: [PATCH mptcp-next v5 11/16] mptcp: add TCP_REPAIR sockopt support

[Geliang Tang <geliang@kernel.org>]

Hi Matt,

On Mon, 2026-09-14 at 12:33 +0200, Matthieu Baerts wrote:
> Hi Geliang,
> 
> (It looks like my email from yesterday didn't get sent)
> 
> On 13/09/2026 12:14, Geliang Tang wrote:
> > From: Geliang Tang <tanggeliang@kylinos.cn>
> > 
> > Add TCP_REPAIR socket option support for MPTCP, required for
> > sockmap CRIU
> > checkpoint/restore. When TCP_REPAIR is set on the first subflow,
> > skip the
> > normal connection handshake in mptcp_connect() and transition
> > directly to
> > TCP_ESTABLISHED. On close, skip the shutdown sequence and jump to
> > cleanup
> > when repair mode is active.
> Just a quick comment here: a lot more is required to support
> TCP_REPAIR,
> see:
> 
>   https://github.com/multipath-tcp/mptcp_net-next/issues/556

Thanks for the info - I'll take a look at that.

> 
> It is not clear to me why you need it to support sockmap. Probably
> better to drop this patch, no?

It's the sockmap_basic test that sets TCP_REPAIR; I can temporarily
disable that test case for MPTCP.

Thanks,
-Geliang

> 
> Cheers,
> Matt