Re: [PATCH mptcp-next v2 07/36] mptcp: make three pm wrappers static

[Matthieu Baerts <matttbe@kernel.org>]

Hi Geliang,

(I'm still reviewing the series, thank you for your patience. Please
wait for me to finish it before sending a v3.)

On 22/10/2024 11:14, Geliang Tang wrote:
> From: Geliang Tang <tanggeliang@kylinos.cn>
> 
> Three path manager wrappers, mptcp_pm_get_addr(), mptcp_pm_dump_addr() and
> mptcp_pm_set_flags() are used to switch the interfaces between in-kernel
> PM and userspace PM. These wrappers are defined in pm.c but only used in
> pm_netlink.c. It makes more sense to move them to pm_netlink.c and make
> them all static.

These three helpers are calling userspace PM code, that looks "strange"
to do that from pm_netlink.

I didn't check, but would it not make more sense to move all the _doit()
functions calling these helpers to pm.c? Also, do we still these helpers
you were moving? Can we not instead remove them, and move their code
directly in the _doit() functions if you see what I mean?

  int mptcp_pm_nl_get_addr_doit(...)
  {
      if (info->attrs[MPTCP_PM_ATTR_TOKEN])
          return mptcp_userspace_pm_get_addr(skb, info);
      return mptcp_pm_nl_get_addr(skb, info);
  }

(in pm.c)

WDYT?

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.