Re: [PATCH mptcp-next v2 12/36] mptcp: change info of get_addr as const

[Matthieu Baerts <matttbe@kernel.org>]

Hi Geliang,

On 22/10/2024 11:14, Geliang Tang wrote:
> From: Geliang Tang <tanggeliang@kylinos.cn>
> 
> get_addr() interfeces will be invoked by dump_addr(), which using const

(typo: s/interfeces/interfaces/)

> parameters "info", so this patch changes "info" parameters of get_addr()
> as const too.
> 
> Signed-off-by: Geliang Tang <tanggeliang@kylinos.cn>
> ---
>  net/mptcp/pm_netlink.c   | 9 ++++++---
>  net/mptcp/pm_userspace.c | 2 +-
>  net/mptcp/protocol.h     | 2 +-
>  3 files changed, 8 insertions(+), 5 deletions(-)
> 
> diff --git a/net/mptcp/pm_netlink.c b/net/mptcp/pm_netlink.c
> index 064fe4d494eb..02e4dda0dc13 100644
> --- a/net/mptcp/pm_netlink.c
> +++ b/net/mptcp/pm_netlink.c
> @@ -1793,12 +1793,15 @@ int mptcp_nl_fill_addr(struct sk_buff *skb,
>  }
>  
>  static int mptcp_pm_nl_get_addr(u8 id, struct mptcp_pm_addr_entry *addr,
> -				struct genl_info *info)
> +				const struct genl_info *info)
>  {
> -	struct pm_nl_pernet *pernet = genl_info_pm_nl(info);
> +	struct net *net = genl_info_net(info);
>  	struct mptcp_pm_addr_entry *entry;
> +	struct pm_nl_pernet *pernet;
>  	int ret = -EINVAL;
>  
> +	pernet = pm_nl_get_pernet(net);

Please mention this modification in the commit message: you didn't only
add the 'const' attribute, you had to do some adaptations.

I guess you can no longer use genl_info_pm_nl() because it doesn't
accept a 'const' variable, but that's OK to get pernet via
genl_info_net(), right? I think that's clearer if we don't have to guess.

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.