From: Florian Westphal <fw at strlen.de>
To: mptcp at lists.01.org
Subject: [MPTCP] Re: [PATCH MPTCP 0/5] mptcp: add reset and fastclose option support
Date: Thu, 12 Nov 2020 10:48:17 +0100 [thread overview]
Message-ID: <20201112094817.GK23619@breakpoint.cc> (raw)
In-Reply-To: 9ca1f43c-105c-afb-3b99-383556309398@linux.intel.com
[-- Attachment #1: Type: text/plain, Size: 951 bytes --]
Mat Martineau <mathew.j.martineau(a)linux.intel.com> wrote:
> I had a couple of minor questions on patch 3, but nothing that would keep
> this from going in to the export branch for some more testing. Might be
> easier to coordinate with Paolo's refactor changes to the workqueue that
> way.
>
> Do the selftests get any code coverage on this, for example in the
> new-subflow-not-allowed case?
How would you do that? I could add a mib counter and check that in the
script. But other than that I do not see how to expose any of this to
the script/mptcp_connect.
> And thanks for looking at packetdrill tests for this,
> saw the conversation on IRC.
Yes, I plan to send a pull request for fastclose and reset.
As for further direction, I think next step is to add genl notifications
so mptcpd can learn about subflows that are added/removed, the reset
code could then be exposed to userspace in the 'subflow was reset'
case.
next reply other threads:[~2020-11-12 9:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-12 9:48 Florian Westphal [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-11-12 22:55 [MPTCP] Re: [PATCH MPTCP 0/5] mptcp: add reset and fastclose option support Mat Martineau
2020-11-12 1:44 Mat Martineau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201112094817.GK23619@breakpoint.cc \
--to=mptcp@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox