[PATCH 5.10.y] selftests: mptcp: depend on SYN_COOKIES

[PATCH 5.10.y] selftests: mptcp: depend on SYN_COOKIES

[Matthieu Baerts]

commit 6c8880fcaa5c45355179b759c1d11737775e31fc upstream.

MPTCP selftests are using TCP SYN Cookies for quite a while now, since
v5.9.

Some CIs don't have this config option enabled and this is causing
issues in the tests:

  # ns1 MPTCP -> ns1 (10.0.1.1:10000      ) MPTCP     (duration   167ms) sysctl: cannot stat /proc/sys/net/ipv4/tcp_syncookies: No such file or directory
  # [ OK ]./mptcp_connect.sh: line 554: [: -eq: unary operator expected

There is no impact in the results but the test is not doing what it is
supposed to do.

Fixes: fed61c4b584c ("selftests: mptcp: make 2nd net namespace use tcp syn cookies unconditionally")
Cc: stable@vger.kernel.org
Signed-off-by: Matthieu Baerts <matthieu.baerts@tessares.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Matthieu Baerts <matthieu.baerts@tessares.net>
---
Backport notes:
  - We don't have kconfig that have been added later, that's normal.
  - Only added the new kconfig dep then.
---
 tools/testing/selftests/net/mptcp/config | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tools/testing/selftests/net/mptcp/config b/tools/testing/selftests/net/mptcp/config
index 1a4c11a444d9..8867c40258b5 100644
--- a/tools/testing/selftests/net/mptcp/config
+++ b/tools/testing/selftests/net/mptcp/config
@@ -6,3 +6,4 @@ CONFIG_INET_DIAG=m
 CONFIG_INET_MPTCP_DIAG=m
 CONFIG_VETH=y
 CONFIG_NET_SCH_NETEM=m
+CONFIG_SYN_COOKIES=y
-- 
2.40.1

Re: [PATCH 5.10.y] selftests: mptcp: depend on SYN_COOKIES

[Greg KH]

On Wed, Jul 26, 2023 at 06:55:47PM +0200, Matthieu Baerts wrote:
> commit 6c8880fcaa5c45355179b759c1d11737775e31fc upstream.
> 
> MPTCP selftests are using TCP SYN Cookies for quite a while now, since
> v5.9.
> 
> Some CIs don't have this config option enabled and this is causing
> issues in the tests:
> 
>   # ns1 MPTCP -> ns1 (10.0.1.1:10000      ) MPTCP     (duration   167ms) sysctl: cannot stat /proc/sys/net/ipv4/tcp_syncookies: No such file or directory
>   # [ OK ]./mptcp_connect.sh: line 554: [: -eq: unary operator expected
> 
> There is no impact in the results but the test is not doing what it is
> supposed to do.
> 
> Fixes: fed61c4b584c ("selftests: mptcp: make 2nd net namespace use tcp syn cookies unconditionally")
> Cc: stable@vger.kernel.org
> Signed-off-by: Matthieu Baerts <matthieu.baerts@tessares.net>
> Signed-off-by: David S. Miller <davem@davemloft.net>
> Signed-off-by: Matthieu Baerts <matthieu.baerts@tessares.net>
> ---
> Backport notes:
>   - We don't have kconfig that have been added later, that's normal.
>   - Only added the new kconfig dep then.
> ---
>  tools/testing/selftests/net/mptcp/config | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tools/testing/selftests/net/mptcp/config b/tools/testing/selftests/net/mptcp/config
> index 1a4c11a444d9..8867c40258b5 100644
> --- a/tools/testing/selftests/net/mptcp/config
> +++ b/tools/testing/selftests/net/mptcp/config
> @@ -6,3 +6,4 @@ CONFIG_INET_DIAG=m
>  CONFIG_INET_MPTCP_DIAG=m
>  CONFIG_VETH=y
>  CONFIG_NET_SCH_NETEM=m
> +CONFIG_SYN_COOKIES=y
> -- 
> 2.40.1
> 

All now queued up, thanks.

greg k-h