MPTCP Linux Development
 help / color / mirror / Atom feed
From: "Matthieu Baerts (NGI0)" <matttbe@kernel.org>
To: MPTCP Upstream <mptcp@lists.linux.dev>
Cc: "Matthieu Baerts (NGI0)" <matttbe@kernel.org>
Subject: [PATCH mptcp-next 0/5] selftests: mptcp: get counters from nstat history
Date: Mon, 03 Nov 2025 20:19:30 +0100	[thread overview]
Message-ID: <20251103-slft-nstat-cache-v1-0-56025c09e56a@kernel.org> (raw)

When debugging MPTCP Join selftest with a "debug" kernel config, I
noticed checking all the different counters was sometimes slower than
the test itself. Fetching the counters once, then reading them from the
history file that was already there seems to save more than 5 minutes
when running the whole MPTCP Join selftest.

- Patch 1: move code to mptcp_lib.sh to prepare the new features.

- Patch 2: simplify mptcp_lib_pr_err_stats helper use.

- Patch 3: remove unused last column from nstat output.

- Patch 4: improve stats dump in mptcp_join.sh.

- Patch 5: get counters from nstat history.

Based-on: <20251102-slft-join-inst-v2-0-b4f3ba15a7c4@kernel.org>

Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
---
Matthieu Baerts (NGI0) (5):
      selftests: mptcp: lib: introduce 'nstat_{init,get}'
      selftests: mptcp: lib: remove stats files args
      selftests: mptcp: lib: stats: remove nstat rate columns
      selftests: mptcp: join: dump stats from history
      selftests: mptcp: lib: get counters from nstat history

 tools/testing/selftests/net/mptcp/mptcp_connect.sh | 100 ++++++++-------------
 tools/testing/selftests/net/mptcp/mptcp_join.sh    |  31 ++++---
 tools/testing/selftests/net/mptcp/mptcp_lib.sh     |  45 ++++++++--
 tools/testing/selftests/net/mptcp/mptcp_sockopt.sh |  15 ++--
 tools/testing/selftests/net/mptcp/simult_flows.sh  |  15 ++--
 5 files changed, 104 insertions(+), 102 deletions(-)
---
base-commit: 1b41f9e417a8db60baf3686b81346131d2d81f30
change-id: 20251101-slft-nstat-cache-db4d2962c5ce

Best regards,
-- 
Matthieu Baerts (NGI0) <matttbe@kernel.org>


             reply	other threads:[~2025-11-03 19:19 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-03 19:19 Matthieu Baerts (NGI0) [this message]
2025-11-03 19:19 ` [PATCH mptcp-next 1/5] selftests: mptcp: lib: introduce 'nstat_{init,get}' Matthieu Baerts (NGI0)
2025-11-03 19:19 ` [PATCH mptcp-next 2/5] selftests: mptcp: lib: remove stats files args Matthieu Baerts (NGI0)
2025-11-03 19:19 ` [PATCH mptcp-next 3/5] selftests: mptcp: lib: stats: remove nstat rate columns Matthieu Baerts (NGI0)
2025-11-03 19:19 ` [PATCH mptcp-next 4/5] selftests: mptcp: join: dump stats from history Matthieu Baerts (NGI0)
2025-11-03 19:19 ` [PATCH mptcp-next 5/5] selftests: mptcp: lib: get counters from nstat history Matthieu Baerts (NGI0)
2025-11-03 20:58 ` [PATCH mptcp-next 0/5] selftests: mptcp: " MPTCP CI
2025-11-04 21:13   ` Paolo Abeni
2025-11-05 10:58     ` Matthieu Baerts

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251103-slft-nstat-cache-v1-0-56025c09e56a@kernel.org \
    --to=matttbe@kernel.org \
    --cc=mptcp@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox