MPTCP Linux Development
 help / color / mirror / Atom feed
From: "Matthieu Baerts (NGI0)" <matttbe@kernel.org>
To: MPTCP Upstream <mptcp@lists.linux.dev>
Cc: "Matthieu Baerts (NGI0)" <matttbe@kernel.org>
Subject: [PATCH mptcp-next 3/5] selftests: mptcp: lib: stats: remove nstat rate columns
Date: Mon, 03 Nov 2025 20:19:33 +0100	[thread overview]
Message-ID: <20251103-slft-nstat-cache-v1-3-56025c09e56a@kernel.org> (raw)
In-Reply-To: <20251103-slft-nstat-cache-v1-0-56025c09e56a@kernel.org>

With the MPTCP selftests, the nstat daemon is not used. It means that
the last column (the rate) is always 0.0, and that's not something
interesting to display.

Then, this last column can be filtered out.

Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
---
 tools/testing/selftests/net/mptcp/mptcp_lib.sh | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tools/testing/selftests/net/mptcp/mptcp_lib.sh b/tools/testing/selftests/net/mptcp/mptcp_lib.sh
index 22ab39749ca2..f59268b25707 100644
--- a/tools/testing/selftests/net/mptcp/mptcp_lib.sh
+++ b/tools/testing/selftests/net/mptcp/mptcp_lib.sh
@@ -369,9 +369,9 @@ mptcp_lib_nstat_init() {
 mptcp_lib_nstat_get() {
 	local ns="${1}"
 
-	# filter out non-*TCP stats
+	# filter out non-*TCP stats, and the rate (last column)
 	NSTAT_HISTORY="/tmp/${ns}.nstat" ip netns exec "${ns}" nstat |
-		grep Tcp > "/tmp/${ns}.out"
+		grep -o ".*Tcp\S\+\s\+[0-9]\+" > "/tmp/${ns}.out"
 }
 
 # $1: ns, $2: MIB counter

-- 
2.51.0


  parent reply	other threads:[~2025-11-03 19:19 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-03 19:19 [PATCH mptcp-next 0/5] selftests: mptcp: get counters from nstat history Matthieu Baerts (NGI0)
2025-11-03 19:19 ` [PATCH mptcp-next 1/5] selftests: mptcp: lib: introduce 'nstat_{init,get}' Matthieu Baerts (NGI0)
2025-11-03 19:19 ` [PATCH mptcp-next 2/5] selftests: mptcp: lib: remove stats files args Matthieu Baerts (NGI0)
2025-11-03 19:19 ` Matthieu Baerts (NGI0) [this message]
2025-11-03 19:19 ` [PATCH mptcp-next 4/5] selftests: mptcp: join: dump stats from history Matthieu Baerts (NGI0)
2025-11-03 19:19 ` [PATCH mptcp-next 5/5] selftests: mptcp: lib: get counters from nstat history Matthieu Baerts (NGI0)
2025-11-03 20:58 ` [PATCH mptcp-next 0/5] selftests: mptcp: " MPTCP CI
2025-11-04 21:13   ` Paolo Abeni
2025-11-05 10:58     ` Matthieu Baerts

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251103-slft-nstat-cache-v1-3-56025c09e56a@kernel.org \
    --to=matttbe@kernel.org \
    --cc=mptcp@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox