MPTCP Linux Development
 help / color / mirror / Atom feed
From: "Matthieu Baerts (NGI0)" <matttbe@kernel.org>
To: MPTCP Upstream <mptcp@lists.linux.dev>
Cc: "Matthieu Baerts (NGI0)" <matttbe@kernel.org>
Subject: [PATCH mptcp-net v5 00/20] mptcp: pm: increase limits, and related fixes and cleanup
Date: Wed, 15 Apr 2026 11:56:48 +0200	[thread overview]
Message-ID: <20260415-mptcp-inc-limits-v5-0-e54c3bf80e4e@kernel.org> (raw)

The initial intension was to increase the limits, but some fixes were
needed, then when looking at the code around, other fixes had to be
added too. So now I ended up with 11 fixes (including one early exit
while at it), followed by 4 patches increasing limits, 3 to validate the
modifications, one small improvement in the selftests, and some
renaming.

The patches with a Fixes tag are for -net, the rest for net-next.

The last patch contains multiple renaming: please tell me what you
think before I start splitting in smaller commits.

Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
---
Changes in v5:
- patch 5: only set timer_done to true in the timer handler: safer.
- patch 9: fix typo in commit message.
- patch 10: 3rd check expects error, better err msg, rename var.
- Link to v4: https://patch.msgid.link/20260414-mptcp-inc-limits-v4-0-78274edda5dd@kernel.org

Changes in v4:
- patch 5: reset timer_done when the timer is reset.
- patch 10: new: selftests: correctly catch error in 'check output'.
- patch 16: add example with init_shapers to silence AI reviews
- Patch 18: clearer way to check errors (without buggy '&&')
- Link to v3: https://patch.msgid.link/20260413-mptcp-inc-limits-v3-0-dd36c9360432@kernel.org

Changes in v3:
- patch 1: new: retransmit ADD_ADDR for ID 0 with right ID.
- patch 5: moved below + support calling sk_free().
- patch 13: new: allow flushing more than 8 endpoints.
- patch 12: clarify single batch of 8 subflows as known limit.
- patch 16: fix typo in comment.
- Link to v2: https://patch.msgid.link/20260410-mptcp-inc-limits-v2-0-5402209f05d3@kernel.org

Changes in v2:
- patch 2: new: fix potential data-race.
- re-order patches 1 to 5 and use shorter prefix (ADD_ADDR rtx).
- patch 6: restore accidentally deleted icsk->icsk_rto > max check.
- patch 16: fix already present checkpatch warning.
- Link to v1: https://patch.msgid.link/20260409-mptcp-inc-limits-v1-0-0e45fa30d914@kernel.org

---
Matthieu Baerts (NGI0) (20):
      mptcp: pm: kernel: correctly retransmit ADD_ADDR ID 0
      mptcp: pm: ADD_ADDR rtx: fix potential data-race
      mptcp: pm: ADD_ADDR rtx: allow ID 0
      mptcp: pm: ADD_ADDR rtx: always decrease sk refcount
      mptcp: pm: ADD_ADDR rtx: free sk if last
      mptcp: pm: ADD_ADDR rtx: resched blocked ADD_ADDR quicker
      mptcp: pm: ADD_ADDR rtx: skip inactive subflows
      mptcp: pm: retrans ADD_ADDR: return early if no retrans
      mptcp: pm: prio: skip closed subflows
      selftests: mptcp: check output: catch cmd errors
      selftests: mptcp: pm: restrict 'unknown' check to pm_nl_ctl
      mptcp: pm: in-kernel: explicitly limit batches to array size
      mptcp: pm: in-kernel: increase all limits to 64
      mptcp: pm: kernel: allow flushing more than 8 endpoints
      mptcp: pm: in-kernel: increase endpoints limit
      selftests: mptcp: join: allow changing ifaces nr per test
      selftests: mptcp: join: validate 8x8 subflows
      selftests: mptcp: pm: validate new limits
      selftests: mptcp: pm: use simpler send/recv forms
      mptcp: pm: clearer ADD_ADDR related helpers names

 net/mptcp/options.c                             |   2 +-
 net/mptcp/pm.c                                  | 182 +++++++++++++-----------
 net/mptcp/pm_kernel.c                           | 106 +++++++++-----
 net/mptcp/pm_userspace.c                        |   6 +-
 net/mptcp/protocol.h                            |  19 +--
 net/mptcp/subflow.c                             |   4 +-
 tools/testing/selftests/net/mptcp/mptcp_join.sh |  33 ++++-
 tools/testing/selftests/net/mptcp/mptcp_lib.sh  |  16 ++-
 tools/testing/selftests/net/mptcp/pm_netlink.sh |  74 ++++++----
 tools/testing/selftests/net/mptcp/pm_nl_ctl.c   |   8 +-
 10 files changed, 276 insertions(+), 174 deletions(-)
---
base-commit: 438914ced649b46cb53b49d7cb5ff99860bbe103
change-id: 20260403-mptcp-inc-limits-ce9811024066

Best regards,
--  
Matthieu Baerts (NGI0) <matttbe@kernel.org>


             reply	other threads:[~2026-04-15  9:58 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-15  9:56 Matthieu Baerts (NGI0) [this message]
2026-04-15  9:56 ` [PATCH mptcp-net v5 01/20] mptcp: pm: kernel: correctly retransmit ADD_ADDR ID 0 Matthieu Baerts (NGI0)
2026-04-15  9:56 ` [PATCH mptcp-net v5 02/20] mptcp: pm: ADD_ADDR rtx: fix potential data-race Matthieu Baerts (NGI0)
2026-04-15  9:56 ` [PATCH mptcp-net v5 03/20] mptcp: pm: ADD_ADDR rtx: allow ID 0 Matthieu Baerts (NGI0)
2026-04-15  9:56 ` [PATCH mptcp-net v5 04/20] mptcp: pm: ADD_ADDR rtx: always decrease sk refcount Matthieu Baerts (NGI0)
2026-04-15 17:09   ` Matthieu Baerts
2026-04-15  9:56 ` [PATCH mptcp-net v5 05/20] mptcp: pm: ADD_ADDR rtx: free sk if last Matthieu Baerts (NGI0)
2026-04-18 18:00   ` Mat Martineau
2026-04-20 17:12     ` Matthieu Baerts
2026-04-20 21:07       ` Mat Martineau
2026-04-15  9:56 ` [PATCH mptcp-net v5 06/20] mptcp: pm: ADD_ADDR rtx: resched blocked ADD_ADDR quicker Matthieu Baerts (NGI0)
2026-04-15  9:56 ` [PATCH mptcp-net v5 07/20] mptcp: pm: ADD_ADDR rtx: skip inactive subflows Matthieu Baerts (NGI0)
2026-04-18 18:09   ` Mat Martineau
2026-04-20 17:18     ` Matthieu Baerts
2026-04-20 21:07       ` Mat Martineau
2026-04-15  9:56 ` [PATCH mptcp-net v5 08/20] mptcp: pm: retrans ADD_ADDR: return early if no retrans Matthieu Baerts (NGI0)
2026-04-15  9:56 ` [PATCH mptcp-net v5 09/20] mptcp: pm: prio: skip closed subflows Matthieu Baerts (NGI0)
2026-04-15  9:56 ` [PATCH mptcp-net v5 10/20] selftests: mptcp: check output: catch cmd errors Matthieu Baerts (NGI0)
2026-04-15  9:56 ` [PATCH mptcp-net v5 11/20] selftests: mptcp: pm: restrict 'unknown' check to pm_nl_ctl Matthieu Baerts (NGI0)
2026-04-15  9:57 ` [PATCH mptcp-net v5 12/20] mptcp: pm: in-kernel: explicitly limit batches to array size Matthieu Baerts (NGI0)
2026-04-15  9:57 ` [PATCH mptcp-net v5 13/20] mptcp: pm: in-kernel: increase all limits to 64 Matthieu Baerts (NGI0)
2026-04-15  9:57 ` [PATCH mptcp-net v5 14/20] mptcp: pm: kernel: allow flushing more than 8 endpoints Matthieu Baerts (NGI0)
2026-04-15  9:57 ` [PATCH mptcp-net v5 15/20] mptcp: pm: in-kernel: increase endpoints limit Matthieu Baerts (NGI0)
2026-04-15 17:10   ` Matthieu Baerts
2026-04-15  9:57 ` [PATCH mptcp-net v5 16/20] selftests: mptcp: join: allow changing ifaces nr per test Matthieu Baerts (NGI0)
2026-04-15  9:57 ` [PATCH mptcp-net v5 17/20] selftests: mptcp: join: validate 8x8 subflows Matthieu Baerts (NGI0)
2026-04-18 18:22   ` Mat Martineau
2026-04-20 17:30     ` Matthieu Baerts
2026-04-20 21:11       ` Mat Martineau
2026-04-15  9:57 ` [PATCH mptcp-net v5 18/20] selftests: mptcp: pm: validate new limits Matthieu Baerts (NGI0)
2026-04-15  9:57 ` [PATCH mptcp-net v5 19/20] selftests: mptcp: pm: use simpler send/recv forms Matthieu Baerts (NGI0)
2026-04-15  9:57 ` [PATCH mptcp-net v5 20/20] mptcp: pm: clearer ADD_ADDR related helpers names Matthieu Baerts (NGI0)
2026-04-18 18:27   ` Mat Martineau
2026-04-20 17:50     ` Matthieu Baerts
2026-04-15 11:32 ` [PATCH mptcp-net v5 00/20] mptcp: pm: increase limits, and related fixes and cleanup MPTCP CI

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260415-mptcp-inc-limits-v5-0-e54c3bf80e4e@kernel.org \
    --to=matttbe@kernel.org \
    --cc=mptcp@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox