From: Matthieu Baerts <matttbe@kernel.org>
To: MPTCP Linux <mptcp@lists.linux.dev>
Subject: Re: [PATCH mptcp-net v5 04/20] mptcp: pm: ADD_ADDR rtx: always decrease sk refcount
Date: Wed, 15 Apr 2026 19:09:22 +0200 [thread overview]
Message-ID: <401b186d-bc9a-4d10-bb1b-cf4d5d9a2dd4@kernel.org> (raw)
In-Reply-To: <20260415-mptcp-inc-limits-v5-4-e54c3bf80e4e@kernel.org>
Hello,
On 15/04/2026 11:56, Matthieu Baerts (NGI0) wrote:
> When an ADD_ADDR is retransmitted, the sk is held in sk_reset_timer().
> It should then be released in all cases at the end.
>
> Some (unlikely) checks were returning directly instead of calling
> sock_put() to decrease the refcount. Jump to the 'out' label to fix this
Detail: after rebasing, it should be 'exit':
Jump to a new 'exit' label to call __sock_put() (which will become
sock_put() in the next commit) to fix this potential leak.
> potential leak.
Cheers,
Matt
--
Sponsored by the NGI0 Core fund.
next prev parent reply other threads:[~2026-04-15 17:09 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-15 9:56 [PATCH mptcp-net v5 00/20] mptcp: pm: increase limits, and related fixes and cleanup Matthieu Baerts (NGI0)
2026-04-15 9:56 ` [PATCH mptcp-net v5 01/20] mptcp: pm: kernel: correctly retransmit ADD_ADDR ID 0 Matthieu Baerts (NGI0)
2026-04-15 9:56 ` [PATCH mptcp-net v5 02/20] mptcp: pm: ADD_ADDR rtx: fix potential data-race Matthieu Baerts (NGI0)
2026-04-15 9:56 ` [PATCH mptcp-net v5 03/20] mptcp: pm: ADD_ADDR rtx: allow ID 0 Matthieu Baerts (NGI0)
2026-04-15 9:56 ` [PATCH mptcp-net v5 04/20] mptcp: pm: ADD_ADDR rtx: always decrease sk refcount Matthieu Baerts (NGI0)
2026-04-15 17:09 ` Matthieu Baerts [this message]
2026-04-15 9:56 ` [PATCH mptcp-net v5 05/20] mptcp: pm: ADD_ADDR rtx: free sk if last Matthieu Baerts (NGI0)
2026-04-18 18:00 ` Mat Martineau
2026-04-20 17:12 ` Matthieu Baerts
2026-04-20 21:07 ` Mat Martineau
2026-04-15 9:56 ` [PATCH mptcp-net v5 06/20] mptcp: pm: ADD_ADDR rtx: resched blocked ADD_ADDR quicker Matthieu Baerts (NGI0)
2026-04-15 9:56 ` [PATCH mptcp-net v5 07/20] mptcp: pm: ADD_ADDR rtx: skip inactive subflows Matthieu Baerts (NGI0)
2026-04-18 18:09 ` Mat Martineau
2026-04-20 17:18 ` Matthieu Baerts
2026-04-20 21:07 ` Mat Martineau
2026-04-15 9:56 ` [PATCH mptcp-net v5 08/20] mptcp: pm: retrans ADD_ADDR: return early if no retrans Matthieu Baerts (NGI0)
2026-04-15 9:56 ` [PATCH mptcp-net v5 09/20] mptcp: pm: prio: skip closed subflows Matthieu Baerts (NGI0)
2026-04-15 9:56 ` [PATCH mptcp-net v5 10/20] selftests: mptcp: check output: catch cmd errors Matthieu Baerts (NGI0)
2026-04-15 9:56 ` [PATCH mptcp-net v5 11/20] selftests: mptcp: pm: restrict 'unknown' check to pm_nl_ctl Matthieu Baerts (NGI0)
2026-04-15 9:57 ` [PATCH mptcp-net v5 12/20] mptcp: pm: in-kernel: explicitly limit batches to array size Matthieu Baerts (NGI0)
2026-04-15 9:57 ` [PATCH mptcp-net v5 13/20] mptcp: pm: in-kernel: increase all limits to 64 Matthieu Baerts (NGI0)
2026-04-15 9:57 ` [PATCH mptcp-net v5 14/20] mptcp: pm: kernel: allow flushing more than 8 endpoints Matthieu Baerts (NGI0)
2026-04-15 9:57 ` [PATCH mptcp-net v5 15/20] mptcp: pm: in-kernel: increase endpoints limit Matthieu Baerts (NGI0)
2026-04-15 17:10 ` Matthieu Baerts
2026-04-15 9:57 ` [PATCH mptcp-net v5 16/20] selftests: mptcp: join: allow changing ifaces nr per test Matthieu Baerts (NGI0)
2026-04-15 9:57 ` [PATCH mptcp-net v5 17/20] selftests: mptcp: join: validate 8x8 subflows Matthieu Baerts (NGI0)
2026-04-18 18:22 ` Mat Martineau
2026-04-20 17:30 ` Matthieu Baerts
2026-04-20 21:11 ` Mat Martineau
2026-04-15 9:57 ` [PATCH mptcp-net v5 18/20] selftests: mptcp: pm: validate new limits Matthieu Baerts (NGI0)
2026-04-15 9:57 ` [PATCH mptcp-net v5 19/20] selftests: mptcp: pm: use simpler send/recv forms Matthieu Baerts (NGI0)
2026-04-15 9:57 ` [PATCH mptcp-net v5 20/20] mptcp: pm: clearer ADD_ADDR related helpers names Matthieu Baerts (NGI0)
2026-04-18 18:27 ` Mat Martineau
2026-04-20 17:50 ` Matthieu Baerts
2026-04-15 11:32 ` [PATCH mptcp-net v5 00/20] mptcp: pm: increase limits, and related fixes and cleanup MPTCP CI
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=401b186d-bc9a-4d10-bb1b-cf4d5d9a2dd4@kernel.org \
--to=matttbe@kernel.org \
--cc=mptcp@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox