* Re: [PATCH net] mptcp: reject DATA_ACKs against a reversed send interval [not found] <20261104130747.1045741-1-edumazet@kernel.org> @ 2026-11-10 19:10 ` Matthieu Baerts 2026-11-10 19:33 ` Jakub Kicinski 0 siblings, 1 reply; 3+ messages in thread From: Matthieu Baerts @ 2026-11-10 19:10 UTC (permalink / raw) To: Eric Dumazet Cc: David S . Miller, Jakub Kicinski, Paolo Abeni, Mat Martineau, Geliang Tang, Simon Horman, Kuniyuki Iwashima, netdev, Kyle Zeng, MPTCP Linux Hi Eric, (+cc MPTCP list) On 04/11/2026 14:07, Eric Dumazet wrote: > From: Kyle Zeng <kylebot@openai.com> > > ack_update_msk() samples snd_nxt before taking the data lock, but reads > snd_una after taking it. Concurrent transmission and ACK processing can > therefore leave the sampled upper bound behind snd_una. Active-open > completion also exposes a reversed interval when it initializes snd_una > to IDSN + 1 while the socket-owned state synchronization is deferred. > > A peer-supplied 64-bit Data ACK half a sequence space away can pass both > wraparound comparisons against such an interval. The resulting snd_una > can make __mptcp_retrans() inflate a fragment's already_sent field. Later > ACKs can then underflow data_len and cause out-of-bounds page fragments > to be passed to TCP. > > Read snd_nxt after acquiring the data lock and reject reversed intervals > before checking the received Data ACK. This keeps the interval shorter > than half the sequence space, so the existing upper-bound check cannot > accept an advance beyond snd_nxt. Preserve the existing handling of old > ACKs and keep the transmit fields under their existing socket locking. Sorry, I missed this patch (the MPTCP CI didn't get it). It looks good to me: Reviewed-by: Matthieu Baerts (NGI0) <matttbe@kernel.org> While at it: Cc: stable@vger.kernel.org @Net Maintainers: this patch can be applied to the net tree directly, thank you! (Or did I miss my review window?) Cheers, Matt -- Sponsored by the NGI0 Core fund. ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net] mptcp: reject DATA_ACKs against a reversed send interval 2026-11-10 19:10 ` [PATCH net] mptcp: reject DATA_ACKs against a reversed send interval Matthieu Baerts @ 2026-11-10 19:33 ` Jakub Kicinski 2026-11-10 19:55 ` Matthieu Baerts 0 siblings, 1 reply; 3+ messages in thread From: Jakub Kicinski @ 2026-11-10 19:33 UTC (permalink / raw) To: Matthieu Baerts Cc: Eric Dumazet, David S . Miller, Paolo Abeni, Mat Martineau, Geliang Tang, Simon Horman, Kuniyuki Iwashima, netdev, Kyle Zeng, MPTCP Linux On Tue, 10 Nov 2026 20:10:37 +0100 Matthieu Baerts wrote: > @Net Maintainers: this patch can be applied to the net tree directly, > thank you! (Or did I miss my review window?) Next time just look at patchwork state instead of asking. ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net] mptcp: reject DATA_ACKs against a reversed send interval 2026-11-10 19:33 ` Jakub Kicinski @ 2026-11-10 19:55 ` Matthieu Baerts 0 siblings, 0 replies; 3+ messages in thread From: Matthieu Baerts @ 2026-11-10 19:55 UTC (permalink / raw) To: Jakub Kicinski Cc: Eric Dumazet, David S . Miller, Paolo Abeni, Mat Martineau, Geliang Tang, Simon Horman, Kuniyuki Iwashima, netdev, Kyle Zeng, MPTCP Linux On 10/11/2026 20:33, Jakub Kicinski wrote: > On Tue, 10 Nov 2026 20:10:37 +0100 Matthieu Baerts wrote: >> @Net Maintainers: this patch can be applied to the net tree directly, >> thank you! (Or did I miss my review window?) > > Next time just look at patchwork state instead of asking. Sorry, it was in awaiting-upstream one and not listed in suie (which makes sense): I wasn't sure if I had to do something else to get it back in suie or if it meant I had to take it in our tree first. It looks like not, so that's understood now! Cheers, Matt -- Sponsored by the NGI0 Core fund. ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-11-10 19:55 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20261104130747.1045741-1-edumazet@kernel.org>
2026-11-10 19:10 ` [PATCH net] mptcp: reject DATA_ACKs against a reversed send interval Matthieu Baerts
2026-11-10 19:33 ` Jakub Kicinski
2026-11-10 19:55 ` Matthieu Baerts
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox