Re: [PATCH mptcp-next] Squash to "DO-NOT-MERGE: mptcp: improve code coverage for CI"

[Matthieu Baerts <matttbe@kernel.org>]

Hi Geliang,

On 04/11/2024 09:28, Geliang Tang wrote:
> When our bpf_selftests are re-built, this error occurs:
> 
>  make[1]: *** No rule to make target 'atomics.lskel.h',
> 			needed by '.../atomics.test.o'.  Stop.
>  make[1]: *** Waiting for unfinished jobs....
>  make[1]: Leaving directory 'tools/testing/selftests/bpf'
>  make: *** [Makefile:259: install] Error 2
>  make: Leaving directory 'tools/testing/selftests'

Ah yes, I already noticed that when checking some stuffs, but I didn't
investigate. Thank you for having looked at this!

> In this case, I had to remove the cache directory .virtme and recompile it
> again. This was very time-consuming.

You don't need to remove the whole ".virtme" directory, you can remove
".virtme/build*" instead, so you still have CCache (from ".virtme/ccache*").

> A workaround patch for this is found in [1]. I don't know why this patch
> has not been upstreamed, but it's in BPF CI environment. I think it's
> necessary to synchronize this modification to MPTCP CI environment as well.

It looks like another version has been applied in bpf-next, even if it
is a fix:

  https://lore.kernel.org/bpf/20240916195919.1872371-2-ihor.solodrai@pm.me/

Do you mind checking it please?

If it works, I can backport it to our tree, and ask BPF maintainers if
they can add these two patches in 'bpf' (fix) instead, because this
issue is present in v6.12, but only fixed in next (v6.13).

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.