From: Geliang Tang <geliang@kernel.org>
To: Matthieu Baerts <matttbe@kernel.org>, mptcp@lists.linux.dev
Subject: Re: [PATCH mptcp-net v2 5/5] selftests: mptcp: connect: print pcap suffix
Date: Wed, 10 Sep 2025 11:31:41 +0800 [thread overview]
Message-ID: <28f9910579c9365d3f774c6892fb6b189b53f2a6.camel@kernel.org> (raw)
In-Reply-To: <79233605-a9e5-4406-9310-bb34063bafee@kernel.org>
Hi Matt,
On Sat, 2025-09-06 at 15:58 +0200, Matthieu Baerts wrote:
> Hi Geliang,
>
> On 06/09/2025 01:39, Geliang Tang wrote:
> > Hi Matt,
> >
> > Thanks for this v2.
> >
> > On Fri, 2025-09-05 at 20:18 +0200, Matthieu Baerts (NGI0) wrote:
> > > To be able to find which capture files have been produced after
> > > several
> > > runs.
> > >
> > > This suffix was not printed anywhere before.
> > >
> > > While at it, always use the same prefix by taking info from ns1,
> > > instead
> > > of "$connector_ns", which is sometimes ns1, sometimes ns2 in the
> > > subtests.
> > >
> > > Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
> > > ---
> > > tools/testing/selftests/net/mptcp/mptcp_connect.sh | 6 +++++-
> >
> > Just wondering, is it necessary to synchronize this modification to
> > mptcp_join.sh to maintain consistency?
>
> I don't think that's needed: there is already a similar message in
> mptcp_join.sh:
>
> Capturing traffic for test $MPTCP_LIB_TEST_COUNTER into $capfile
Thank you for your explanation.
-Geliang
>
> Cheers,
> Matt
next prev parent reply other threads:[~2025-09-10 3:31 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-05 18:18 [PATCH mptcp-net v2 0/5] selftests: mptcp: avoid spurious errors on TCP disconnect Matthieu Baerts (NGI0)
2025-09-05 18:18 ` [PATCH mptcp-net v2 1/5] mptcp: propagate shutdown to subflows when possible Matthieu Baerts (NGI0)
2025-09-06 0:45 ` Geliang Tang
2025-09-06 13:42 ` Matthieu Baerts
2025-09-10 3:24 ` Geliang Tang
2025-09-10 8:56 ` Matthieu Baerts
2025-09-06 0:47 ` Geliang Tang
2025-09-05 18:18 ` [PATCH mptcp-net v2 2/5] selftests: mptcp: connect: catch IO errors on listen side Matthieu Baerts (NGI0)
2025-09-05 23:49 ` Geliang Tang
2025-09-06 13:54 ` Matthieu Baerts
2025-09-10 2:44 ` Geliang Tang
2025-09-10 8:56 ` Matthieu Baerts
2025-09-05 18:18 ` [PATCH mptcp-net v2 3/5] selftests: mptcp: avoid spurious errors on TCP disconnect Matthieu Baerts (NGI0)
2025-09-05 18:18 ` [PATCH mptcp-net v2 4/5] selftests: mptcp: print trailing bytes with od Matthieu Baerts (NGI0)
2025-09-05 23:42 ` Geliang Tang
2025-09-06 13:56 ` Matthieu Baerts
2025-09-10 3:26 ` Geliang Tang
2025-09-05 18:18 ` [PATCH mptcp-net v2 5/5] selftests: mptcp: connect: print pcap suffix Matthieu Baerts (NGI0)
2025-09-05 23:39 ` Geliang Tang
2025-09-06 13:58 ` Matthieu Baerts
2025-09-10 3:31 ` Geliang Tang [this message]
2025-09-05 20:46 ` [PATCH mptcp-net v2 0/5] selftests: mptcp: avoid spurious errors on TCP disconnect MPTCP CI
2025-09-06 14:00 ` Matthieu Baerts
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=28f9910579c9365d3f774c6892fb6b189b53f2a6.camel@kernel.org \
--to=geliang@kernel.org \
--cc=matttbe@kernel.org \
--cc=mptcp@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox