Re: [PATCH mptcp-net v2 5/5] selftests: mptcp: connect: print pcap suffix

[Matthieu Baerts <matttbe@kernel.org>]

Hi Geliang,

On 06/09/2025 01:39, Geliang Tang wrote:
> Hi Matt,
> 
> Thanks for this v2.
> 
> On Fri, 2025-09-05 at 20:18 +0200, Matthieu Baerts (NGI0) wrote:
>> To be able to find which capture files have been produced after
>> several
>> runs.
>>
>> This suffix was not printed anywhere before.
>>
>> While at it, always use the same prefix by taking info from ns1,
>> instead
>> of "$connector_ns", which is sometimes ns1, sometimes ns2 in the
>> subtests.
>>
>> Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
>> ---
>>  tools/testing/selftests/net/mptcp/mptcp_connect.sh | 6 +++++-
> 
> Just wondering, is it necessary to synchronize this modification to
> mptcp_join.sh to maintain consistency?

I don't think that's needed: there is already a similar message in
mptcp_join.sh:

  Capturing traffic for test $MPTCP_LIB_TEST_COUNTER into $capfile

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.