MPTCP Linux Development
 help / color / mirror / Atom feed
From: Geliang Tang <geliang@kernel.org>
To: Paolo Abeni <pabeni@redhat.com>, mptcp@lists.linux.dev
Subject: Re: [PATCH v2 mptcp-net 0/2] mptcp: fix duplicate reset
Date: Tue, 11 Nov 2025 10:31:55 +0800	[thread overview]
Message-ID: <290d95bf919a3f0dac7c50d934bf6aef0790b597.camel@kernel.org> (raw)
In-Reply-To: <cover.1762500073.git.pabeni@redhat.com>

Hi Paolo,

On Fri, 2025-11-07 at 08:23 +0100, Paolo Abeni wrote:
> The actual fix is in patch 2/2, while patch 1/2 is there just to make
> the change tidy/more easily reviewable.
> ---
> v1 -> v2:
>   - drop FASTCLOSE flag entirely

Apart from a nit in patch 2, this set looks good to me.

    Reviewed-by: Geliang Tang <geliang@kernel.org>

Note: As discussed in v1, with this set, "selftests: mptcp: join:
fastclose: drop plain RST" should be reverted.

Thanks,
-Geliang

> 
> Paolo Abeni (2):
>   mptcp: decouple mptcp fastclose from tcp close
>   mptcp: fix duplicate reset on fastclose
> 
>  net/mptcp/protocol.c | 50 ++++++++++++++++++++++++++++--------------
> --
>  1 file changed, 32 insertions(+), 18 deletions(-)
> 


  parent reply	other threads:[~2025-11-11  2:31 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-07  7:23 [PATCH v2 mptcp-net 0/2] mptcp: fix duplicate reset Paolo Abeni
2025-11-07  7:23 ` [PATCH v2 mptcp-net 1/2] mptcp: decouple mptcp fastclose from tcp close Paolo Abeni
2025-11-11 11:24   ` Matthieu Baerts
2025-11-07  7:23 ` [PATCH v2 mptcp-net 2/2] mptcp: fix duplicate reset on fastclose Paolo Abeni
2025-11-11  1:59   ` Geliang Tang
2025-11-11  6:14     ` Matthieu Baerts
2025-11-11  7:27       ` Paolo Abeni
2025-11-11  7:49         ` Geliang Tang
2025-11-11 11:24   ` Matthieu Baerts
2025-11-07  8:30 ` [PATCH v2 mptcp-net 0/2] mptcp: fix duplicate reset MPTCP CI
2025-11-11  2:31 ` Geliang Tang [this message]
2025-11-11 15:54 ` Matthieu Baerts

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=290d95bf919a3f0dac7c50d934bf6aef0790b597.camel@kernel.org \
    --to=geliang@kernel.org \
    --cc=mptcp@lists.linux.dev \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox