MPTCP Linux Development
 help / color / mirror / Atom feed
From: Matthieu Baerts <matttbe@kernel.org>
To: Paolo Abeni <pabeni@redhat.com>, mptcp@lists.linux.dev
Cc: geliang@kernel.org
Subject: Re: [PATCH v2 mptcp-net 1/2] mptcp: decouple mptcp fastclose from tcp close
Date: Tue, 11 Nov 2025 12:24:34 +0100	[thread overview]
Message-ID: <ee194395-a955-4a55-b469-8ab8f0a20904@kernel.org> (raw)
In-Reply-To: <235288b5bd06f28f5df094cd27bcd33bdcbf34f3.1762500073.git.pabeni@redhat.com>

Hi Paolo,

On 07/11/2025 08:23, Paolo Abeni wrote:
> With the current fastclose implementation, the mptcp_do_fastclose() helper
> is in charge of two distinct actions: send the fastclose reset and cleanup
> the subflows.
> 
> Formally decouple the two steps, ensuring that mptcp explicitly closes all
> the subflows after the mentioned helper.
> 
> This will make the upcoming fix simpler, and allows dropping the 2nd
> argument from mptcp_destroy_common().

I suggest adding the same Fixes tag here, just to ease the backports (to
ensure this patch is automatically picked up):

Fixes: d21f83485518 ("mptcp: use fastclose on more edge scenarios")

I'm going to add the following text to the previous paragraph:

  The Fixes tag is the same as in the next commit, simply to ease the
  backports.

Thank you for the patch!

Reviewed-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.


  reply	other threads:[~2025-11-11 11:24 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-07  7:23 [PATCH v2 mptcp-net 0/2] mptcp: fix duplicate reset Paolo Abeni
2025-11-07  7:23 ` [PATCH v2 mptcp-net 1/2] mptcp: decouple mptcp fastclose from tcp close Paolo Abeni
2025-11-11 11:24   ` Matthieu Baerts [this message]
2025-11-07  7:23 ` [PATCH v2 mptcp-net 2/2] mptcp: fix duplicate reset on fastclose Paolo Abeni
2025-11-11  1:59   ` Geliang Tang
2025-11-11  6:14     ` Matthieu Baerts
2025-11-11  7:27       ` Paolo Abeni
2025-11-11  7:49         ` Geliang Tang
2025-11-11 11:24   ` Matthieu Baerts
2025-11-07  8:30 ` [PATCH v2 mptcp-net 0/2] mptcp: fix duplicate reset MPTCP CI
2025-11-11  2:31 ` Geliang Tang
2025-11-11 15:54 ` Matthieu Baerts

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ee194395-a955-4a55-b469-8ab8f0a20904@kernel.org \
    --to=matttbe@kernel.org \
    --cc=geliang@kernel.org \
    --cc=mptcp@lists.linux.dev \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox