[PATCH mptcp-next] Squash to "selftests: bpf: add MPTCP test base"

[PATCH mptcp-next] Squash to "selftests: bpf: add MPTCP test base"

[Geliang Tang]

Update newly added files in MAINTAINERS.

Signed-off-by: Geliang Tang <geliang.tang@suse.com>
---
 MAINTAINERS | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index d91f6c6e3d3b..778cbf7c5a3b 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -13745,6 +13745,8 @@ F:	include/net/mptcp.h
 F:	include/trace/events/mptcp.h
 F:	include/uapi/linux/mptcp.h
 F:	net/mptcp/
+F:	tools/testing/selftests/bpf/progs/mptcp_sock.c
+F:	tools/testing/selftests/bpf/prog_tests/mptcp.c
 F:	tools/testing/selftests/net/mptcp/
 
 NETWORKING [TCP]
-- 
2.34.1

Re: Squash to "selftests: bpf: add MPTCP test base": Tests Results

[MPTCP CI]

Hi Geliang,

Thank you for your modifications, that's great!

Our CI did some validations and here is its report:

- KVM Validation: normal:
  - Success! ✅:
  - Task: https://cirrus-ci.com/task/5976582060769280
  - Summary: https://api.cirrus-ci.com/v1/artifact/task/5976582060769280/summary/summary.txt

- KVM Validation: debug:
  - Unstable: 1 failed test(s): selftest_mptcp_join 🔴:
  - Task: https://cirrus-ci.com/task/5413632107347968
  - Summary: https://api.cirrus-ci.com/v1/artifact/task/5413632107347968/summary/summary.txt

Initiator: Patchew Applier
Commits: https://github.com/multipath-tcp/mptcp_net-next/commits/4a7e6dd72b59

Please note that despite all the efforts that have been already done to have a
stable tests suite when executed on a public CI like here, it is possible some
reported issues are not due to your modifications. Still, do not hesitate to
help us improve that ;-)

Cheers,
MPTCP GH Action bot
Bot operated by Matthieu Baerts (Tessares)

Re: [PATCH mptcp-next] Squash to "selftests: bpf: add MPTCP test base"

[Matthieu Baerts]

Hi Geliang,

On 31/03/2022 10:14, Geliang Tang wrote:
> Update newly added files in MAINTAINERS.
> 
> Signed-off-by: Geliang Tang <geliang.tang@suse.com>
> ---
>  MAINTAINERS | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index d91f6c6e3d3b..778cbf7c5a3b 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -13745,6 +13745,8 @@ F:	include/net/mptcp.h
>  F:	include/trace/events/mptcp.h
>  F:	include/uapi/linux/mptcp.h
>  F:	net/mptcp/
> +F:	tools/testing/selftests/bpf/progs/mptcp_sock.c
> +F:	tools/testing/selftests/bpf/prog_tests/mptcp.c

Thank you for the patch. I applied it a bit differently:

  tools/testing/selftests/bpf/*/*mptcp*.c

See commit 4a7ea84d46b3 ("MAINTAINERS: add MPTCP-specific BPF files"),
being published soon.

Cheers,
Matt
-- 
Tessares | Belgium | Hybrid Access Solutions
www.tessares.net

[PATCH mptcp-next] Squash to "selftests: bpf: add MPTCP test base"

[Geliang Tang]

Add CONFIG_IKCONFIG and CONFIG_IKCONFIG_PROC as Mat suggested.

Signed-off-by: Geliang Tang <geliang.tang@suse.com>
---
 tools/testing/selftests/bpf/config | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/tools/testing/selftests/bpf/config b/tools/testing/selftests/bpf/config
index fe0d3ad6ecd8..f3391d0abe58 100644
--- a/tools/testing/selftests/bpf/config
+++ b/tools/testing/selftests/bpf/config
@@ -54,3 +54,5 @@ CONFIG_NF_DEFRAG_IPV6=y
 CONFIG_NF_CONNTRACK=y
 CONFIG_USERFAULTFD=y
 CONFIG_MPTCP=y
+CONFIG_IKCONFIG=y
+CONFIG_IKCONFIG_PROC=y
-- 
2.34.1

Re: Squash to "selftests: bpf: add MPTCP test base": Tests Results

[MPTCP CI]

Hi Geliang,

Thank you for your modifications, that's great!

Our CI did some validations and here is its report:

- KVM Validation: normal:
  - Success! ✅:
  - Task: https://cirrus-ci.com/task/5557640280408064
  - Summary: https://api.cirrus-ci.com/v1/artifact/task/5557640280408064/summary/summary.txt

- KVM Validation: debug:
  - Unstable: 2 failed test(s): selftest_diag selftest_mptcp_join 🔴:
  - Task: https://cirrus-ci.com/task/6683540187250688
  - Summary: https://api.cirrus-ci.com/v1/artifact/task/6683540187250688/summary/summary.txt

Initiator: Patchew Applier
Commits: https://github.com/multipath-tcp/mptcp_net-next/commits/915cd06abad0


If there are some issues, you can reproduce them using the same environment as
the one used by the CI thanks to a docker image, e.g.:

    $ cd [kernel source code]
    $ docker run -v "${PWD}:${PWD}:rw" -w "${PWD}" --privileged --rm -it \
        --pull always mptcp/mptcp-upstream-virtme-docker:latest \
        auto-debug

For more details:

    https://github.com/multipath-tcp/mptcp-upstream-virtme-docker


Please note that despite all the efforts that have been already done to have a
stable tests suite when executed on a public CI like here, it is possible some
reported issues are not due to your modifications. Still, do not hesitate to
help us improve that ;-)

Cheers,
MPTCP GH Action bot
Bot operated by Matthieu Baerts (Tessares)