* Re: selftests: mptcp: rm subflow with v4/v4mapped addr: Tests Results
2024-02-07 1:55 ` [PATCH mptcp-next v3 2/2] selftests: mptcp: rm subflow with v4/v4mapped addr Geliang Tang
@ 2024-02-07 2:49 ` MPTCP CI
2024-02-07 3:11 ` MPTCP CI
` (3 subsequent siblings)
4 siblings, 0 replies; 11+ messages in thread
From: MPTCP CI @ 2024-02-07 2:49 UTC (permalink / raw)
To: Geliang Tang; +Cc: mptcp
Hi Geliang,
Thank you for your modifications, that's great!
Our CI (GitHub Action) did some validations and here is its report:
- KVM Validation: normal:
- Success! ✅:
- Task: https://github.com/multipath-tcp/mptcp_net-next/actions/runs/7808971609
Initiator: Patchew Applier
Commits: https://github.com/multipath-tcp/mptcp_net-next/commits/d954c612ab76
If there are some issues, you can reproduce them using the same environment as
the one used by the CI thanks to a docker image, e.g.:
$ cd [kernel source code]
$ docker run -v "${PWD}:${PWD}:rw" -w "${PWD}" --privileged --rm -it \
--pull always mptcp/mptcp-upstream-virtme-docker:latest \
auto-normal
For more details:
https://github.com/multipath-tcp/mptcp-upstream-virtme-docker
Please note that despite all the efforts that have been already done to have a
stable tests suite when executed on a public CI like here, it is possible some
reported issues are not due to your modifications. Still, do not hesitate to
help us improve that ;-)
Cheers,
MPTCP GH Action bot
Bot operated by Matthieu Baerts (NGI0 Core)
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: selftests: mptcp: rm subflow with v4/v4mapped addr: Tests Results
2024-02-07 1:55 ` [PATCH mptcp-next v3 2/2] selftests: mptcp: rm subflow with v4/v4mapped addr Geliang Tang
2024-02-07 2:49 ` selftests: mptcp: rm subflow with v4/v4mapped addr: Tests Results MPTCP CI
@ 2024-02-07 3:11 ` MPTCP CI
2024-02-14 2:36 ` MPTCP CI
` (2 subsequent siblings)
4 siblings, 0 replies; 11+ messages in thread
From: MPTCP CI @ 2024-02-07 3:11 UTC (permalink / raw)
To: Geliang Tang; +Cc: mptcp
Hi Geliang,
Thank you for your modifications, that's great!
Our CI (Cirrus) did some validations with a debug kernel and here is its report:
- KVM Validation: debug (except selftest_mptcp_join):
- Success! ✅:
- Task: https://cirrus-ci.com/task/5682143834144768
- Summary: https://api.cirrus-ci.com/v1/artifact/task/5682143834144768/summary/summary.txt
- KVM Validation: debug (only selftest_mptcp_join):
- Unstable: 1 failed test(s): selftest_mptcp_join 🔴:
- Task: https://cirrus-ci.com/task/5119193880723456
- Summary: https://api.cirrus-ci.com/v1/artifact/task/5119193880723456/summary/summary.txt
Initiator: Patchew Applier
Commits: https://github.com/multipath-tcp/mptcp_net-next/commits/d954c612ab76
If there are some issues, you can reproduce them using the same environment as
the one used by the CI thanks to a docker image, e.g.:
$ cd [kernel source code]
$ docker run -v "${PWD}:${PWD}:rw" -w "${PWD}" --privileged --rm -it \
--pull always mptcp/mptcp-upstream-virtme-docker:latest \
auto-debug
For more details:
https://github.com/multipath-tcp/mptcp-upstream-virtme-docker
Please note that despite all the efforts that have been already done to have a
stable tests suite when executed on a public CI like here, it is possible some
reported issues are not due to your modifications. Still, do not hesitate to
help us improve that ;-)
Cheers,
MPTCP GH Action bot
Bot operated by Matthieu Baerts (NGI0 Core)
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: selftests: mptcp: rm subflow with v4/v4mapped addr: Tests Results
2024-02-07 1:55 ` [PATCH mptcp-next v3 2/2] selftests: mptcp: rm subflow with v4/v4mapped addr Geliang Tang
2024-02-07 2:49 ` selftests: mptcp: rm subflow with v4/v4mapped addr: Tests Results MPTCP CI
2024-02-07 3:11 ` MPTCP CI
@ 2024-02-14 2:36 ` MPTCP CI
2024-02-14 2:55 ` MPTCP CI
2024-02-14 10:18 ` [PATCH mptcp-next v3 2/2] selftests: mptcp: rm subflow with v4/v4mapped addr Matthieu Baerts
4 siblings, 0 replies; 11+ messages in thread
From: MPTCP CI @ 2024-02-14 2:36 UTC (permalink / raw)
To: Geliang Tang; +Cc: mptcp
Hi Geliang,
Thank you for your modifications, that's great!
Our CI (GitHub Action) did some validations and here is its report:
- KVM Validation: normal:
- Success! ✅:
- Task: https://github.com/multipath-tcp/mptcp_net-next/actions/runs/7895424329
Initiator: Patchew Applier
Commits: https://github.com/multipath-tcp/mptcp_net-next/commits/9b8ecb217a79
If there are some issues, you can reproduce them using the same environment as
the one used by the CI thanks to a docker image, e.g.:
$ cd [kernel source code]
$ docker run -v "${PWD}:${PWD}:rw" -w "${PWD}" --privileged --rm -it \
--pull always mptcp/mptcp-upstream-virtme-docker:latest \
auto-normal
For more details:
https://github.com/multipath-tcp/mptcp-upstream-virtme-docker
Please note that despite all the efforts that have been already done to have a
stable tests suite when executed on a public CI like here, it is possible some
reported issues are not due to your modifications. Still, do not hesitate to
help us improve that ;-)
Cheers,
MPTCP GH Action bot
Bot operated by Matthieu Baerts (NGI0 Core)
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: selftests: mptcp: rm subflow with v4/v4mapped addr: Tests Results
2024-02-07 1:55 ` [PATCH mptcp-next v3 2/2] selftests: mptcp: rm subflow with v4/v4mapped addr Geliang Tang
` (2 preceding siblings ...)
2024-02-14 2:36 ` MPTCP CI
@ 2024-02-14 2:55 ` MPTCP CI
2024-02-14 10:18 ` [PATCH mptcp-next v3 2/2] selftests: mptcp: rm subflow with v4/v4mapped addr Matthieu Baerts
4 siblings, 0 replies; 11+ messages in thread
From: MPTCP CI @ 2024-02-14 2:55 UTC (permalink / raw)
To: Geliang Tang; +Cc: mptcp
Hi Geliang,
Thank you for your modifications, that's great!
Our CI (Cirrus) did some validations with a debug kernel and here is its report:
- KVM Validation: debug (except selftest_mptcp_join):
- Success! ✅:
- Task: https://cirrus-ci.com/task/5714999662870528
- Summary: https://api.cirrus-ci.com/v1/artifact/task/5714999662870528/summary/summary.txt
- KVM Validation: debug (only selftest_mptcp_join):
- Unstable: 1 failed test(s): selftest_mptcp_join 🔴:
- Task: https://cirrus-ci.com/task/5152049709449216
- Summary: https://api.cirrus-ci.com/v1/artifact/task/5152049709449216/summary/summary.txt
Initiator: Patchew Applier
Commits: https://github.com/multipath-tcp/mptcp_net-next/commits/9b8ecb217a79
If there are some issues, you can reproduce them using the same environment as
the one used by the CI thanks to a docker image, e.g.:
$ cd [kernel source code]
$ docker run -v "${PWD}:${PWD}:rw" -w "${PWD}" --privileged --rm -it \
--pull always mptcp/mptcp-upstream-virtme-docker:latest \
auto-debug
For more details:
https://github.com/multipath-tcp/mptcp-upstream-virtme-docker
Please note that despite all the efforts that have been already done to have a
stable tests suite when executed on a public CI like here, it is possible some
reported issues are not due to your modifications. Still, do not hesitate to
help us improve that ;-)
Cheers,
MPTCP GH Action bot
Bot operated by Matthieu Baerts (NGI0 Core)
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PATCH mptcp-next v3 2/2] selftests: mptcp: rm subflow with v4/v4mapped addr
2024-02-07 1:55 ` [PATCH mptcp-next v3 2/2] selftests: mptcp: rm subflow with v4/v4mapped addr Geliang Tang
` (3 preceding siblings ...)
2024-02-14 2:55 ` MPTCP CI
@ 2024-02-14 10:18 ` Matthieu Baerts
2024-02-14 11:47 ` Geliang Tang
4 siblings, 1 reply; 11+ messages in thread
From: Matthieu Baerts @ 2024-02-14 10:18 UTC (permalink / raw)
To: Geliang Tang, mptcp; +Cc: Geliang Tang
Hi Geliang,
On 07/02/2024 02:55, Geliang Tang wrote:
> From: Geliang Tang <tanggeliang@kylinos.cn>
>
> Now both a v4 address and a v4-mapped address are supported when
> destroying a userspace pm subflow, this patch adds a second subflow
> to "userspace pm add & remove address" test, and two subflows could
> be removed two different ways, one with the v4mapped and one with v4.
Thank you for validating this.
> diff --git a/tools/testing/selftests/net/mptcp/mptcp_lib.sh b/tools/testing/selftests/net/mptcp/mptcp_lib.sh
> index 3a2abae5993e..69001d2a8dab 100644
> --- a/tools/testing/selftests/net/mptcp/mptcp_lib.sh
> +++ b/tools/testing/selftests/net/mptcp/mptcp_lib.sh
> @@ -213,9 +213,12 @@ mptcp_lib_get_info_value() {
> grep "${2}" | sed -n 's/.*\('"${1}"':\)\([0-9a-f:.]*\).*$/\2/p;q'
> }
>
> -# $1: info name ; $2: evts_ns ; $3: event type
> +# $1: info name ; $2: evts_ns ; $3: event type; $4: addr
> mptcp_lib_evts_get_info() {
> - mptcp_lib_get_info_value "${1}" "^type:${3:-1}," < "${2}"
> + local addr=${4:-""}
> +
> + cat "${2}" | grep "${addr}" |
> + mptcp_lib_get_info_value "${1}" "^type:${3:-1},"
When modifying shell scripts, please make sure 'shellcheck' is happy
with the modifications you did.
> $ shellcheck -x mptcp_lib.sh
>
> In mptcp_lib.sh line 220:
> cat "${2}" | grep "${addr}" |
> ^----^ SC2002 (style): Useless cat. Consider 'cmd < file | ..' or 'cmd file | ..' instead.
>
> For more information:
> https://www.shellcheck.net/wiki/SC2002 -- Useless cat. Consider 'cmd < file...
I then did this modification when applying the patch:
> diff --git a/tools/testing/selftests/net/mptcp/mptcp_lib.sh b/tools/testing/selftests/net/mptcp/mptcp_lib.sh
> index 69001d2a8dab..3777d66fc56d 100644
> --- a/tools/testing/selftests/net/mptcp/mptcp_lib.sh
> +++ b/tools/testing/selftests/net/mptcp/mptcp_lib.sh
> @@ -213,12 +213,9 @@ mptcp_lib_get_info_value() {
> grep "${2}" | sed -n 's/.*\('"${1}"':\)\([0-9a-f:.]*\).*$/\2/p;q'
> }
>
> -# $1: info name ; $2: evts_ns ; $3: event type; $4: addr
> +# $1: info name ; $2: evts_ns ; [$3: event type; [$4: addr]]
> mptcp_lib_evts_get_info() {
> - local addr=${4:-""}
> -
> - cat "${2}" | grep "${addr}" |
> - mptcp_lib_get_info_value "${1}" "^type:${3:-1},"
> + grep "${4:-}" "${2}" | mptcp_lib_get_info_value "${1}" "^type:${3:-1},"
> }
>
> # $1: PID
Note that it is not strictly needed to add ':-' in '${4:-}' (we don't
use 'set -u'), but it clearly shows the argument is optional.
I also edited the comment above the declaration of the function to
reflect that.
About 'shellcheck', please note that for the moment, not all scripts are
shellcheck compliant, only 'mptcp_join.sh', 'mptcp_lib.sh' and
'userspace_pm.sh'. For the others, it would be great if at the least the
new code is shellcheck compliant. I don't think it is needed to modify
the existing ones, they are not often modified and they work. (Except
maybe if there are some other big modifications needed.)
Also, some checks can be ignored with '# shellcheck disable=XXXX'
directive if needed:
https://www.shellcheck.net/wiki/Ignore
Cheers,
Matt
--
Sponsored by the NGI0 Core fund.
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PATCH mptcp-next v3 2/2] selftests: mptcp: rm subflow with v4/v4mapped addr
2024-02-14 10:18 ` [PATCH mptcp-next v3 2/2] selftests: mptcp: rm subflow with v4/v4mapped addr Matthieu Baerts
@ 2024-02-14 11:47 ` Geliang Tang
0 siblings, 0 replies; 11+ messages in thread
From: Geliang Tang @ 2024-02-14 11:47 UTC (permalink / raw)
To: Matthieu Baerts; +Cc: mptcp
Hi Matt,
On Wed, Feb 14, 2024 at 11:18:04AM +0100, Matthieu Baerts wrote:
> Hi Geliang,
>
> On 07/02/2024 02:55, Geliang Tang wrote:
> > From: Geliang Tang <tanggeliang@kylinos.cn>
> >
> > Now both a v4 address and a v4-mapped address are supported when
> > destroying a userspace pm subflow, this patch adds a second subflow
> > to "userspace pm add & remove address" test, and two subflows could
> > be removed two different ways, one with the v4mapped and one with v4.
>
> Thank you for validating this.
>
> > diff --git a/tools/testing/selftests/net/mptcp/mptcp_lib.sh b/tools/testing/selftests/net/mptcp/mptcp_lib.sh
> > index 3a2abae5993e..69001d2a8dab 100644
> > --- a/tools/testing/selftests/net/mptcp/mptcp_lib.sh
> > +++ b/tools/testing/selftests/net/mptcp/mptcp_lib.sh
> > @@ -213,9 +213,12 @@ mptcp_lib_get_info_value() {
> > grep "${2}" | sed -n 's/.*\('"${1}"':\)\([0-9a-f:.]*\).*$/\2/p;q'
> > }
> >
> > -# $1: info name ; $2: evts_ns ; $3: event type
> > +# $1: info name ; $2: evts_ns ; $3: event type; $4: addr
> > mptcp_lib_evts_get_info() {
> > - mptcp_lib_get_info_value "${1}" "^type:${3:-1}," < "${2}"
> > + local addr=${4:-""}
> > +
> > + cat "${2}" | grep "${addr}" |
> > + mptcp_lib_get_info_value "${1}" "^type:${3:-1},"
>
> When modifying shell scripts, please make sure 'shellcheck' is happy
> with the modifications you did.
Sure, I'll use shellcheck to check my script modifications next time.
>
> > $ shellcheck -x mptcp_lib.sh
> >
> > In mptcp_lib.sh line 220:
> > cat "${2}" | grep "${addr}" |
> > ^----^ SC2002 (style): Useless cat. Consider 'cmd < file | ..' or 'cmd file | ..' instead.
> >
> > For more information:
> > https://www.shellcheck.net/wiki/SC2002 -- Useless cat. Consider 'cmd < file...
>
> I then did this modification when applying the patch:
Thanks a lot.
-Geliang
>
> > diff --git a/tools/testing/selftests/net/mptcp/mptcp_lib.sh b/tools/testing/selftests/net/mptcp/mptcp_lib.sh
> > index 69001d2a8dab..3777d66fc56d 100644
> > --- a/tools/testing/selftests/net/mptcp/mptcp_lib.sh
> > +++ b/tools/testing/selftests/net/mptcp/mptcp_lib.sh
> > @@ -213,12 +213,9 @@ mptcp_lib_get_info_value() {
> > grep "${2}" | sed -n 's/.*\('"${1}"':\)\([0-9a-f:.]*\).*$/\2/p;q'
> > }
> >
> > -# $1: info name ; $2: evts_ns ; $3: event type; $4: addr
> > +# $1: info name ; $2: evts_ns ; [$3: event type; [$4: addr]]
> > mptcp_lib_evts_get_info() {
> > - local addr=${4:-""}
> > -
> > - cat "${2}" | grep "${addr}" |
> > - mptcp_lib_get_info_value "${1}" "^type:${3:-1},"
> > + grep "${4:-}" "${2}" | mptcp_lib_get_info_value "${1}" "^type:${3:-1},"
> > }
> >
> > # $1: PID
>
> Note that it is not strictly needed to add ':-' in '${4:-}' (we don't
> use 'set -u'), but it clearly shows the argument is optional.
>
> I also edited the comment above the declaration of the function to
> reflect that.
>
> About 'shellcheck', please note that for the moment, not all scripts are
> shellcheck compliant, only 'mptcp_join.sh', 'mptcp_lib.sh' and
> 'userspace_pm.sh'. For the others, it would be great if at the least the
> new code is shellcheck compliant. I don't think it is needed to modify
> the existing ones, they are not often modified and they work. (Except
> maybe if there are some other big modifications needed.)
>
> Also, some checks can be ignored with '# shellcheck disable=XXXX'
> directive if needed:
>
> https://www.shellcheck.net/wiki/Ignore
>
> Cheers,
> Matt
> --
> Sponsored by the NGI0 Core fund.
^ permalink raw reply [flat|nested] 11+ messages in thread