From: Matthieu Baerts <matttbe@kernel.org>
To: Geliang Tang <geliang@kernel.org>, mptcp@lists.linux.dev
Cc: Geliang Tang <tanggeliang@kylinos.cn>
Subject: Re: [PATCH mptcp-net v2 2/3] selftests: mptcp: close IPC descriptor on server side
Date: Wed, 3 Sep 2025 16:48:45 +0200 [thread overview]
Message-ID: <2fa5c27a-336e-4551-9ce1-090f7210dd05@kernel.org> (raw)
In-Reply-To: <d512f8fc-a0ac-4c23-9a13-0b5c4e1ed20f@kernel.org>
Hi Geliang,
On 03/09/2025 13:57, Matthieu Baerts wrote:
> Hi Geliang,
>
> On 03/09/2025 06:08, Geliang Tang wrote:
>> From: Geliang Tang <tanggeliang@kylinos.cn>
>>
>> The client-side function 'connect_one_server()' correctly closes the IPC
>> descriptor (a pipe or UNIX socket) after use. However, the server-side
>> functions 'process_one_client()' in both 'mptcp_sockopt.c' and 'mptcp_inq.c'
FYI, checkpatch is complaining that this line is too long.
https://github.com/multipath-tcp/mptcp_net-next/actions/runs/17423040753
Because it is not an output of a log, can you go to the next line after
max 72 chars please?
(I didn't check, but there are other similar errors reported by
checkpatch. *If they make sense*, don't hesitate to fix them as well)
Cheers,
Matt
--
Sponsored by the NGI0 Core fund.
next prev parent reply other threads:[~2025-09-03 14:48 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-03 4:08 [PATCH mptcp-net v2 0/3] misc fixes for sockopt selftests Geliang Tang
2025-09-03 4:08 ` [PATCH mptcp-net v2 1/3] selftests: mptcp: close server file descriptor Geliang Tang
2025-09-03 4:08 ` [PATCH mptcp-net v2 2/3] selftests: mptcp: close IPC descriptor on server side Geliang Tang
2025-09-03 11:57 ` Matthieu Baerts
2025-09-03 14:48 ` Matthieu Baerts [this message]
2025-09-04 8:26 ` Geliang Tang
2025-09-10 17:00 ` Matthieu Baerts
2025-09-11 9:13 ` Geliang Tang
2025-09-11 9:43 ` Matthieu Baerts
2025-09-03 4:08 ` [PATCH mptcp-net v2 3/3] selftests: mptcp: sockopt: fix error messages Geliang Tang
2025-09-03 15:25 ` Matthieu Baerts
2025-09-03 6:10 ` [PATCH mptcp-net v2 0/3] misc fixes for sockopt selftests MPTCP CI
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2fa5c27a-336e-4551-9ce1-090f7210dd05@kernel.org \
--to=matttbe@kernel.org \
--cc=geliang@kernel.org \
--cc=mptcp@lists.linux.dev \
--cc=tanggeliang@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox