Re: [PATCH mptcp-net v2 2/3] selftests: mptcp: close IPC descriptor on server side

[Matthieu Baerts <matttbe@kernel.org>]

Hi Geliang,

On 03/09/2025 06:08, Geliang Tang wrote:
> From: Geliang Tang <tanggeliang@kylinos.cn>
> 
> The client-side function 'connect_one_server()' correctly closes the IPC
> descriptor (a pipe or UNIX socket) after use. However, the server-side
> functions 'process_one_client()' in both 'mptcp_sockopt.c' and 'mptcp_inq.c'
> were missing the corresponding 'close()' call for their IPC descriptors.
> 
> This omission could lead to resource leaks (file descriptors) in the test
> server processes over time.
> 
> This patch adds the missing 'close(pipefd)' and 'close(unixfd)' calls in the
> server-side code, ensuring symmetric and correct resource cleanup.

I don't know if we need such patch. I mean: yes, that's better to close
such FD before closing the application, but then:

- it is strange to close it in the middle of a function
(process_one_client()), and not where it has been created (main())

- if I'm not mistaken, unixfds[0] / pipefds[0] are not closed in the
server process.

So if you really want to fix that, I think it would be better to close
all these unix FD in the 'main()' function, no?

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.