[MPTCP] Re: [PATCH mptcp-next] mptcp: push pending frames when subflow has free space

[MPTCP] Re: [PATCH mptcp-next] mptcp: push pending frames when subflow has free space

[Mat Martineau]

[-- Attachment #1: Type: text/plain, Size: 1136 bytes --]


On Wed, 9 Dec 2020, Paolo Abeni wrote:

> When multiple subflows are active, we can receive a
> window update on subflow with no write space available.
> MPTCP will try to push frames on such subflow and will
> fail. Pending frames will be pushed only after receiving
> a window update on a subflow with some wspace available.
>
> Overall the above could lead to suboptimal aggregate
> bandwidth usage.
>
> Instead, we should try to push pending frames as soon as
> the subflow reaches both conditions mentioned above.
>
> We can finally enable self-tests with asymmetric links,
> as the above makes them finally pass.
>
> Signed-off-by: Paolo Abeni <pabeni(a)redhat.com>
> ---
> net/mptcp/options.c                               | 13 ++++++++-----
> net/mptcp/protocol.c                              |  2 +-
> net/mptcp/protocol.h                              |  2 +-
> tools/testing/selftests/net/mptcp/simult_flows.sh |  6 +++---
> 4 files changed, 13 insertions(+), 10 deletions(-)

Hi Paolo -

Looks good!

Reviewed-by: Mat Martineau <mathew.j.martineau(a)linux.intel.com>

--
Mat Martineau
Intel

[MPTCP] Re: [PATCH mptcp-next] mptcp: push pending frames when subflow has free space

[Matthieu Baerts]

[-- Attachment #1: Type: text/plain, Size: 1013 bytes --]

Hi Paolo, Mat,

On 09/12/2020 18:46, Paolo Abeni wrote:
> When multiple subflows are active, we can receive a
> window update on subflow with no write space available.
> MPTCP will try to push frames on such subflow and will
> fail. Pending frames will be pushed only after receiving
> a window update on a subflow with some wspace available.
> 
> Overall the above could lead to suboptimal aggregate
> bandwidth usage.
> 
> Instead, we should try to push pending frames as soon as
> the subflow reaches both conditions mentioned above.
> 
> We can finally enable self-tests with asymmetric links,
> as the above makes them finally pass.
> 
> Signed-off-by: Paolo Abeni <pabeni(a)redhat.com>

Thank you for the patch and the review!
Just applied in our tree:

- bbaa11040198: mptcp: push pending frames when subflow has free space
- Results: 3f7872297b23..ffc63be6523f

Tests + export are in progress!

Cheers,
Matt
-- 
Tessares | Belgium | Hybrid Access Solutions
www.tessares.net