From: Matthieu Baerts <matttbe@kernel.org>
To: Geliang Tang <geliang@kernel.org>, mptcp@lists.linux.dev
Cc: Geliang Tang <tanggeliang@kylinos.cn>
Subject: Re: [PATCH mptcp-next v4 0/5] Squash to "Add mptcp_subflow bpf_iter support"
Date: Tue, 10 Dec 2024 12:42:29 +0100 [thread overview]
Message-ID: <423e6c05-f564-4853-bb62-0b09c7ceb68f@kernel.org> (raw)
In-Reply-To: <cover.1733733573.git.tanggeliang@kylinos.cn>
Hi Geliang,
On 09/12/2024 09:47, Geliang Tang wrote:
> From: Geliang Tang <tanggeliang@kylinos.cn>
>
> v4:
> - CI reports the following BUILD_BUG_ON fails on i386:
>
> BUILD_BUG_ON(sizeof(struct bpf_iter_mptcp_subflow_kern) !=
> sizeof(struct bpf_iter_mptcp_subflow))
>
> Just like in bpf_iter_task_new(), change this "!=" to ">".
>
> v3:
> - check sock_owned_by_user_nocheck(sk)/spin_is_locked(&sk->sk_lock.slock),
> instead of lockdep_sock_is_held(sk).
> - add "sizeof" and "alignof" checks.
> - drop bpf_mptcp_sk() and bpf_mptcp_subflow_tcp_sock() definitions. Use
> bpf_skc_to_mptcp_sock() and mptcp_subflow_tcp_sock() in mptcp_subflow
> bpf_iter selftests instead.
Thank you for the new versions. I have some additional questions, see my
comment on the individual patches.
Cheers,
Matt
--
Sponsored by the NGI0 Core fund.
next prev parent reply other threads:[~2024-12-10 11:42 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-09 8:47 [PATCH mptcp-next v4 0/5] Squash to "Add mptcp_subflow bpf_iter support" Geliang Tang
2024-12-09 8:47 ` [PATCH mptcp-next v4 1/5] mptcp: update bpf_mptcp_sock_from_subflow Geliang Tang
2024-12-10 11:43 ` Matthieu Baerts
2024-12-09 8:47 ` [PATCH mptcp-next v4 2/5] bpf: Allow use of skc_to_mptcp_sock in cg_sockopt Geliang Tang
2024-12-10 11:44 ` Matthieu Baerts
2024-12-09 8:47 ` [PATCH mptcp-next v4 3/5] Squash to "bpf: Register mptcp common kfunc set" Geliang Tang
2024-12-10 11:46 ` Matthieu Baerts
2024-12-09 8:47 ` [PATCH mptcp-next v4 4/5] Squash to "bpf: Add mptcp_subflow bpf_iter" Geliang Tang
2024-12-10 11:48 ` Matthieu Baerts
2024-12-11 3:42 ` Geliang Tang
2024-12-09 8:47 ` [PATCH mptcp-next v4 5/5] Squash to "selftests/bpf: Add mptcp_subflow bpf_iter subtest" Geliang Tang
2024-12-09 9:52 ` [PATCH mptcp-next v4 0/5] Squash to "Add mptcp_subflow bpf_iter support" MPTCP CI
2024-12-10 11:42 ` Matthieu Baerts [this message]
-- strict thread matches above, loose matches on Subject: below --
2025-02-24 3:37 Geliang Tang
2025-02-24 3:56 ` Geliang Tang
2025-02-24 4:47 ` MPTCP CI
2025-02-24 11:59 ` Matthieu Baerts
2025-02-26 1:05 ` Mat Martineau
2025-03-05 15:31 ` Matthieu Baerts
2025-03-06 1:50 ` Geliang Tang
2025-03-06 8:38 ` Matthieu Baerts
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=423e6c05-f564-4853-bb62-0b09c7ceb68f@kernel.org \
--to=matttbe@kernel.org \
--cc=geliang@kernel.org \
--cc=mptcp@lists.linux.dev \
--cc=tanggeliang@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox