Re: [PATCH mptcp-next v4 0/5] Squash to "Add mptcp_subflow bpf_iter support"

[Matthieu Baerts <matttbe@kernel.org>]

Hi Geliang,

On 06/03/2025 02:50, Geliang Tang wrote:
> Hi Matt,
> 
> On Mon, 2025-02-24 at 11:37 +0800, Geliang Tang wrote:
>> From: Geliang Tang <tanggeliang@kylinos.cn>
>>
>> v4:
>>  - drop sock_owned_by_user_nocheck and spin_is_locked. According to
>>    comments from Mat and Martin, in this set mptcp_subflow
>>    bpf_iter only used from a cg sockopt bpf prog, no need to add
>> these
>>    check at this moment.
>>
>> v3:
>>  - patch 3, continue to use sock_owned_by_user_nocheck() and
>> spin_is_locked()
>> checks instead of using msk_owned_by_me().
>>  - patch 5, drop declaration of bpf_mptcp_subflow_tcp_sock. It's no
>> longer
>> used.
>>  - patch 5, update the comment for mptcp_subflow_tcp_sock(), which is
>> a BPF
>> helper, not a kfunc.
>>
>> The commit log of "bpf: Register mptcp common kfunc set" doesn't
>> match the
>> code, please update it as:
>>
>> '''
>> bpf: Register mptcp common kfunc set
>>
>> MPTCP helper mptcp_subflow_ctx() is used to convert struct sock to
>> struct mptcp_subflow_context. It will be used in MPTCP BPF programs.
>>
>> This patch defines corresponding wrapper of this helper, and put it
>> into the newly defined mptcp common kfunc set and register this set
>> with the flag BPF_PROG_TYPE_CGROUP_SOCKOPT to let it accessible to
>> the 'cgroup/getsockopt' type of BPF programs.
>> '''
> 
> Thanks for applying this set. Please update this commit log too.

Done. The modification will be visible soon:

New patches for t/upstream:
- 061566ebfca8: tg:msg: adapt 'bpf: Register mptcp common kfunc set'
- Results: 6c4b1c674680..ccf37aa90567 (export)

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.