Re: [PATCH mptcp-next 1/2] mptcp: only allow set existing scheduler for net.mptcp.scheduler

[Matthieu Baerts <matttbe@kernel.org>]

On 30/04/2024 14:06, Gregory Detal wrote:
> The current behavior is to accept any strings as inputs, this results in
> an inconsistent result where an unexisting scheduler can be set:
> 
>  # sysctl -w net.mptcp.scheduler=notdefault
>  net.mptcp.scheduler = notdefault
> 
> This patch changes this behavior by checking for existing scheduler
> before accepting the input.
> 
> Fixes: e3b2870b6d22 ("mptcp: add a new sysctl scheduler")
> Signed-off-by: Gregory Detal <gregory.detal@gmail.com>
> ---
>  net/mptcp/ctrl.c | 40 +++++++++++++++++++++++++++++++++++++++-
>  1 file changed, 39 insertions(+), 1 deletion(-)
> 
> diff --git a/net/mptcp/ctrl.c b/net/mptcp/ctrl.c
> index 8d661156ab8c..0e69bd0ea302 100644
> --- a/net/mptcp/ctrl.c
> +++ b/net/mptcp/ctrl.c
> @@ -96,6 +96,44 @@ static void mptcp_pernet_set_defaults(struct mptcp_pernet *pernet)
>  }
>  
>  #ifdef CONFIG_SYSCTL
> +

We can remove this extra new line here: I can do that when applying the
patches if I don't forget.

> +static int mptcp_set_scheduler(const struct net *net, const char *name)
(...)

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.