From: Geliang Tang <geliang@kernel.org>
To: Gregory Detal <gregory.detal@gmail.com>
Cc: Matthieu Baerts <matttbe@kernel.org>,
Mat Martineau <martineau@kernel.org>,
mptcp@lists.linux.dev
Subject: Re: [PATCH mptcp-next 0/2] mptcp: fix net.mptcp.scheduler behavior
Date: Thu, 2 May 2024 22:16:53 +0800 [thread overview]
Message-ID: <ZjOgVXcBcSj3gI5l@T480> (raw)
In-Reply-To: <bd99d542-0397-45e1-826c-93f514376c67@kernel.org>
Hi Gregory,
On Tue, Apr 30, 2024 at 04:00:17PM +0200, Matthieu Baerts wrote:
> Hi Gregory,
>
> On 30/04/2024 14:06, Gregory Detal wrote:
> > The sysctl is accepting any input. This patchset ensures only
> > existing scheduler can be set.
> >
> > Moreover, this adds an helper sysctl to list the available scheduler
> > similarly to tcp_available_congestion_control.
> >
> > The first patch of the series is a fix for mptcp-net.
>
> Thank you for this fix, it makes sense! And thanks for the new sysctl
> entry, it will be useful!
>
> Reviewed-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
Thanks for these patches, all tests passed.
Tested-by: Geliang Tang <geliang@kernel.org>
-Geliang
>
> @Mat / @Geliang: because I did a review "internally" with Gregory, do
> not hesitate to have a quick look to have an external point of view :)
>
> Cheers,
> Matt
> --
> Sponsored by the NGI0 Core fund.
>
next prev parent reply other threads:[~2024-05-02 14:16 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-30 12:06 [PATCH mptcp-next 0/2] mptcp: fix net.mptcp.scheduler behavior Gregory Detal
2024-04-30 12:06 ` [PATCH mptcp-next 1/2] mptcp: only allow set existing scheduler for net.mptcp.scheduler Gregory Detal
2024-04-30 14:00 ` Matthieu Baerts
2024-04-30 12:06 ` [PATCH mptcp-next 2/2] mptcp: add net.mptcp.available_schedulers Gregory Detal
2024-04-30 12:59 ` [PATCH mptcp-next 0/2] mptcp: fix net.mptcp.scheduler behavior MPTCP CI
2024-04-30 14:00 ` Matthieu Baerts
2024-04-30 14:00 ` Matthieu Baerts
2024-05-02 14:16 ` Geliang Tang [this message]
2024-05-03 1:04 ` Mat Martineau
2024-05-03 16:45 ` Matthieu Baerts
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZjOgVXcBcSj3gI5l@T480 \
--to=geliang@kernel.org \
--cc=gregory.detal@gmail.com \
--cc=martineau@kernel.org \
--cc=matttbe@kernel.org \
--cc=mptcp@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox