Re: Squash to "selftests: mptcp: add MP_FAIL reset testcase" - cleanups: Tests Results

Re: Squash to "selftests: mptcp: add MP_FAIL reset testcase" - cleanups: Tests Results

[MPTCP CI]

Hi Geliang,

Thank you for your modifications, that's great!

Our CI did some validations and here is its report:

- KVM Validation: normal:
  - Script error! ❓:
  - Task: https://cirrus-ci.com/task/5972194063810560
  - Summary: https://api.cirrus-ci.com/v1/artifact/task/5972194063810560/summary/summary.txt

- KVM Validation: debug:
  - Script error! ❓:
  - Task: https://cirrus-ci.com/task/5409244110389248
  - Summary: https://api.cirrus-ci.com/v1/artifact/task/5409244110389248/summary/summary.txt

Initiator: Patchew Applier
Commits: https://github.com/multipath-tcp/mptcp_net-next/commits/cd2b6a887541


If there are some issues, you can reproduce them using the same environment as
the one used by the CI thanks to a docker image, e.g.:

    $ cd [kernel source code]
    $ docker run -v "${PWD}:${PWD}:rw" -w "${PWD}" --privileged --rm -it \
        --pull always mptcp/mptcp-upstream-virtme-docker:latest \
        auto-debug

For more details:

    https://github.com/multipath-tcp/mptcp-upstream-virtme-docker


Please note that despite all the efforts that have been already done to have a
stable tests suite when executed on a public CI like here, it is possible some
reported issues are not due to your modifications. Still, do not hesitate to
help us improve that ;-)

Cheers,
MPTCP GH Action bot
Bot operated by Matthieu Baerts (Tessares)

[PATCH mptcp-next v2] Squash to "selftests: mptcp: add MP_FAIL reset testcase" - cleanups

[Geliang Tang]

Drop '+'s passed to chk_csum_nr, with Paolo's fix [1] for act_pedit, no
extra checksum failures now, no need to add '+'s anymore.

[1]
net/sched: act_pedit: really ensure the skb is writable

Signed-off-by: Geliang Tang <geliang.tang@suse.com>
---
v2:
 - keep test file sizes unchanged.
---
 tools/testing/selftests/net/mptcp/mptcp_join.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/testing/selftests/net/mptcp/mptcp_join.sh b/tools/testing/selftests/net/mptcp/mptcp_join.sh
index a5e90532eaea..1a41f9ba00c6 100755
--- a/tools/testing/selftests/net/mptcp/mptcp_join.sh
+++ b/tools/testing/selftests/net/mptcp/mptcp_join.sh
@@ -2740,7 +2740,7 @@ fail_tests()
 		pm_nl_set_limits $ns2 0 1
 		pm_nl_add_endpoint $ns2 10.0.2.2 dev ns2eth2 flags subflow
 		run_tests $ns1 $ns2 10.0.1.1 1024
-		chk_join_nr 1 1 1 +1 +0 1 1 0 "$(pedit_action_pkts)"
+		chk_join_nr 1 1 1 1 0 1 1 0 "$(pedit_action_pkts)"
 	fi
 }
 
-- 
2.34.1

Re: Squash to "selftests: mptcp: add MP_FAIL reset testcase" - cleanups: Tests Results

[MPTCP CI]

Hi Geliang,

Thank you for your modifications, that's great!

Our CI did some validations and here is its report:

- KVM Validation: normal:
  - Unstable: 2 failed test(s): selftest_mptcp_join selftest_simult_flows 🔴:
  - Task: https://cirrus-ci.com/task/5938569435938816
  - Summary: https://api.cirrus-ci.com/v1/artifact/task/5938569435938816/summary/summary.txt

- KVM Validation: debug:
  - Unstable: 3 failed test(s): packetdrill_add_addr selftest_diag selftest_mptcp_join 🔴:
  - Task: https://cirrus-ci.com/task/5375619482517504
  - Summary: https://api.cirrus-ci.com/v1/artifact/task/5375619482517504/summary/summary.txt

Initiator: Patchew Applier
Commits: https://github.com/multipath-tcp/mptcp_net-next/commits/9174503a1b5a


If there are some issues, you can reproduce them using the same environment as
the one used by the CI thanks to a docker image, e.g.:

    $ cd [kernel source code]
    $ docker run -v "${PWD}:${PWD}:rw" -w "${PWD}" --privileged --rm -it \
        --pull always mptcp/mptcp-upstream-virtme-docker:latest \
        auto-debug

For more details:

    https://github.com/multipath-tcp/mptcp-upstream-virtme-docker


Please note that despite all the efforts that have been already done to have a
stable tests suite when executed on a public CI like here, it is possible some
reported issues are not due to your modifications. Still, do not hesitate to
help us improve that ;-)

Cheers,
MPTCP GH Action bot
Bot operated by Matthieu Baerts (Tessares)

Re: [PATCH mptcp-next v2] Squash to "selftests: mptcp: add MP_FAIL reset testcase" - cleanups

[Matthieu Baerts]

Hi Geliang, Mat,

On 05/05/2022 06:19, Geliang Tang wrote:
> Drop '+'s passed to chk_csum_nr, with Paolo's fix [1] for act_pedit, no
> extra checksum failures now, no need to add '+'s anymore.
> 
> [1]
> net/sched: act_pedit: really ensure the skb is writable

Thank you for the patch and the review!

- f0356d33bafd: "squashed" in "selftests: mptcp: add MP_FAIL reset testcase"
- Results: 9a52d7243fda..9a06ad1b6cf2 (export)

Builds and tests are now in progress:

https://cirrus-ci.com/github/multipath-tcp/mptcp_net-next/export/20220506T192929
https://github.com/multipath-tcp/mptcp_net-next/actions/workflows/build-validation.yml?query=branch:export

Cheers,
Matt
-- 
Tessares | Belgium | Hybrid Access Solutions
www.tessares.net