Re: [PATCH mptcp-next] mptcp: remove unused returned value

[Geliang Tang <geliang@kernel.org>]

Hi Matt,

On Wed, 2025-09-10 at 11:38 +0800, Geliang Tang wrote:
> Hi Matt,
> 
> On Sat, 2025-09-06 at 16:13 +0200, Matthieu Baerts (NGI0) wrote:
> > When working on a fix modifying mptcp_check_data_fin(), I noticed
> > the
> > returned value was no longer used.
> > 
> > It looks like it was used for 3 days, between commit 7ed90803a213
> > ("mptcp: send explicit ack on delayed ack_seq incr") and commit
> > ea4ca586b16f ("mptcp: refine MPTCP-level ack scheduling").
> > 
> > This returned value can be safely removed.
> > 
> > Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
> 
> LGTM!
> 
> Reviewed-by: Geliang Tang <geliang@kernel.org>

Please update the subject when applying this patch, similar to this:

mptcp: remove unused returned value of check_data_fin

Thanks,
-Geliang

> 
> Thanks,
> -Geliang
> 
> > ---
> >  net/mptcp/protocol.c | 5 +----
> >  1 file changed, 1 insertion(+), 4 deletions(-)
> > 
> > diff --git a/net/mptcp/protocol.c b/net/mptcp/protocol.c
> > index
> > 1c26acf6c4145896ecbb5c7f7004121c66a20649..f3dda47ad1d70b5c6a326c17d
> > be
> > 6d244c5638ca2 100644
> > --- a/net/mptcp/protocol.c
> > +++ b/net/mptcp/protocol.c
> > @@ -530,11 +530,10 @@ static void mptcp_cleanup_rbuf(struct
> > mptcp_sock *msk, int copied)
> >  	}
> >  }
> >  
> > -static bool mptcp_check_data_fin(struct sock *sk)
> > +static void mptcp_check_data_fin(struct sock *sk)
> >  {
> >  	struct mptcp_sock *msk = mptcp_sk(sk);
> >  	u64 rcv_data_fin_seq;
> > -	bool ret = false;
> >  
> >  	/* Need to ack a DATA_FIN received from a peer while this
> > side
> >  	 * of the connection is in ESTABLISHED, FIN_WAIT1, or
> > FIN_WAIT2.
> > @@ -572,12 +571,10 @@ static bool mptcp_check_data_fin(struct sock
> > *sk)
> >  			break;
> >  		}
> >  
> > -		ret = true;
> >  		if (!__mptcp_check_fallback(msk))
> >  			mptcp_send_ack(msk);
> >  		mptcp_close_wake_up(sk);
> >  	}
> > -	return ret;
> >  }
> >  
> >  static void mptcp_dss_corruption(struct mptcp_sock *msk, struct
> > sock
> > *ssk)
> > 
> > ---
> > base-commit: e9091ee333eb716a0933dcb08617228dcd3d3623
> > change-id: 20250906-check_data_fin_ret-6d284170880a
> > 
> > Best regards,