From: Matthieu Baerts <matttbe@kernel.org>
To: Geliang Tang <geliang@kernel.org>, mptcp@lists.linux.dev
Subject: Re: [PATCH mptcp-next] mptcp: remove unused returned value
Date: Wed, 10 Sep 2025 11:07:38 +0200 [thread overview]
Message-ID: <71ed4279-c45e-42d4-b3d4-6604582b47ef@kernel.org> (raw)
In-Reply-To: <4b75974ccfc64501c417a75d697e630821fc02b1.camel@kernel.org>
Hi Geliang,
On 10/09/2025 05:44, Geliang Tang wrote:
> Hi Matt,
>
> On Wed, 2025-09-10 at 11:38 +0800, Geliang Tang wrote:
>> Hi Matt,
>>
>> On Sat, 2025-09-06 at 16:13 +0200, Matthieu Baerts (NGI0) wrote:
>>> When working on a fix modifying mptcp_check_data_fin(), I noticed
>>> the
>>> returned value was no longer used.
>>>
>>> It looks like it was used for 3 days, between commit 7ed90803a213
>>> ("mptcp: send explicit ack on delayed ack_seq incr") and commit
>>> ea4ca586b16f ("mptcp: refine MPTCP-level ack scheduling").
>>>
>>> This returned value can be safely removed.
>>>
>>> Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
>>
>> LGTM!
>>
>> Reviewed-by: Geliang Tang <geliang@kernel.org>
>
> Please update the subject when applying this patch, similar to this:
>
> mptcp: remove unused returned value of check_data_fin
Done. Thank you for the review!
Now in our tree:
New patches for t/upstream:
- f99b062ae907: mptcp: remove unused returned value of check_data_fin
- Results: 1e51af26b216..2356642572b2 (export)
Tests are now in progress:
- export:
https://github.com/multipath-tcp/mptcp_net-next/commit/961890711378b6cf214799da98794038222fc86a/checks
Cheers,
Matt
--
Sponsored by the NGI0 Core fund.
prev parent reply other threads:[~2025-09-10 9:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-06 14:13 [PATCH mptcp-next] mptcp: remove unused returned value Matthieu Baerts (NGI0)
2025-09-06 16:19 ` MPTCP CI
2025-09-10 3:38 ` Geliang Tang
2025-09-10 3:44 ` Geliang Tang
2025-09-10 9:07 ` Matthieu Baerts [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=71ed4279-c45e-42d4-b3d4-6604582b47ef@kernel.org \
--to=matttbe@kernel.org \
--cc=geliang@kernel.org \
--cc=mptcp@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox