MPTCP Linux Development
 help / color / mirror / Atom feed
From: Matthieu Baerts <matttbe@kernel.org>
To: Paolo Abeni <pabeni@redhat.com>
Cc: mptcp@lists.linux.dev
Subject: Re: [PATCH mptcp-net 0/3] mptcp: fix memcg accounting for passive sockets
Date: Wed, 12 Nov 2025 10:58:02 +0100	[thread overview]
Message-ID: <4e15d638-b6b8-4daa-aa88-321678bf4824@kernel.org> (raw)
In-Reply-To: <209462dc-d6a1-424e-a93f-0414e21e759f@redhat.com>

On 12/11/2025 10:35, Paolo Abeni wrote:
> On 11/11/25 6:26 PM, Matthieu Baerts wrote:
>> Hi Paolo,
>>
>> On 07/11/2025 22:55, Paolo Abeni wrote:
>>> It turns out that the splat reported earlier is indeed due to an old
>>> bug/missing feature that hit hard on top of "mptcp: borrow forward 
>>> memory from subflow", as we can borrow accounted memory from a socket
>>> not doing any accounting;)
>>>
>>> It should land upstream before the above mentioned commit, ence the
>>> 'net' target, but it could as well be net-next material.
>>
>> Thank you for these fixes!
>>
>> They look good to me for 'net':
>>
>> Reviewed-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
> 
> If you don't have applied these patches yet, please wait a bit: I'll
> send a new revision including a minor delta to make 'Squash-to: "mptcp:
> leverage the backlog for RX packet processing"' smaller/less ugly.

I was going to apply them to help you not to have to carry many patches,
but I can sure wait! :)

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.


  reply	other threads:[~2025-11-12  9:58 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-07 21:55 [PATCH mptcp-net 0/3] mptcp: fix memcg accounting for passive sockets Paolo Abeni
2025-11-07 21:55 ` [PATCH mptcp-net 1/3] net: factor-out _sk_charge() helper Paolo Abeni
2025-11-11  7:24   ` Geliang Tang
2025-11-11 17:38   ` Matthieu Baerts
2025-11-12  9:04     ` Paolo Abeni
2025-11-12  9:16       ` Matthieu Baerts
2025-11-12  9:28         ` Paolo Abeni
2025-11-12  9:55           ` Matthieu Baerts
2025-11-07 21:55 ` [PATCH mptcp-net 2/3] mptcp: factor-out cgroup data inherit helper Paolo Abeni
2025-11-11  7:24   ` Geliang Tang
2025-11-07 21:55 ` [PATCH mptcp-net 3/3] mptcp: fix memcg accounting for passive sockets Paolo Abeni
2025-11-11  8:37   ` Geliang Tang
2025-11-11 17:25     ` Matthieu Baerts
2025-11-12  9:10       ` Paolo Abeni
2025-11-08 15:15 ` [PATCH mptcp-net 0/3] " MPTCP CI
2025-11-11 17:26 ` Matthieu Baerts
2025-11-12  9:35   ` Paolo Abeni
2025-11-12  9:58     ` Matthieu Baerts [this message]
2025-11-12 10:10 ` Matthieu Baerts

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4e15d638-b6b8-4daa-aa88-321678bf4824@kernel.org \
    --to=matttbe@kernel.org \
    --cc=mptcp@lists.linux.dev \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox