Re: [PATCH mptcp-net 0/3] mptcp: fix memcg accounting for passive sockets

[Matthieu Baerts <matttbe@kernel.org>]

Hi Paolo,

On 07/11/2025 22:55, Paolo Abeni wrote:
> It turns out that the splat reported earlier is indeed due to an old
> bug/missing feature that hit hard on top of "mptcp: borrow forward 
> memory from subflow", as we can borrow accounted memory from a socket
> not doing any accounting;)
> 
> It should land upstream before the above mentioned commit, ence the
> 'net' target, but it could as well be net-next material.

Thank you for these fixes!

They look good to me for 'net':

Reviewed-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>

> I think there is still a racing window to produce the splat reported in
> #597: if a subflow receive data while the msk is locked, and before the
> memcg is initialized on such subflow, it will push the data into the msk
> becklog, and later borrow will again try to grab accounted memory from
> non accounting ssk.
> 
> I have a tentative fix for that one but it's quite ugly and I'll keep it
> separate from this series.

Good idea!

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.