[MPTCP] Re: [MPTCP][PATCH v2 mptcp-next] selftests: mptcp: add command line arguments for mptcp_join.sh

[MPTCP] Re: [MPTCP][PATCH v2 mptcp-next] selftests: mptcp: add command line arguments for mptcp_join.sh

[Mat Martineau]

[-- Attachment #1: Type: text/plain, Size: 1388 bytes --]

On Thu, 14 Jan 2021, Geliang Tang wrote:

> Since the mptcp_join script is becoming too big, this patch split it into
> several smaller trunks, each of them has been defined in a function as a
> individual test group for several related testcases.
>
> Using bash getopts function to parse command line arguments, and involk

One very minor thing, maybe Matthieu could fix "invoke" in the line above 
when applying?

Otherwise, looks good to me.

Thanks,

Mat


> each function to do the individual test group.
>
> Here are all the arguments:
>  -f subflows_tests
>  -s signal_address_tests
>  -l link_failure_tests
>  -t add_addr_timeout_tests
>  -r remove_tests
>  -a add_tests
>  -6 ipv6_tests
>  -4 v4mapped_tests
>  -b backup_tests
>  -p add_addr_ports_tests
>  -c syncookies_tests
>  -h help
>
> Run mptcp_join.sh with no argument will do all the testcases.
>
> Signed-off-by: Geliang Tang <geliangtang(a)gmail.com>
> ---
> v2:
> - rebase on export/20210113T185637
> - please apply this patchset after the following patchsets:
>    add IPv4-mapped address support (v5)
>    mptcp: create subflow for newly added address and testcases (v5)
>    ADD_ADDR: ports support (v10)
> ---
> .../testing/selftests/net/mptcp/mptcp_join.sh | 1068 +++++++++--------
> 1 file changed, 590 insertions(+), 478 deletions(-)
>

--
Mat Martineau
Intel

[MPTCP] Re: [MPTCP][PATCH v2 mptcp-next] selftests: mptcp: add command line arguments for mptcp_join.sh

[Matthieu Baerts]

[-- Attachment #1: Type: text/plain, Size: 882 bytes --]

Hi Geliang, Mat,

On 15/01/2021 02:22, Mat Martineau wrote:
> On Thu, 14 Jan 2021, Geliang Tang wrote:
> 
>> Since the mptcp_join script is becoming too big, this patch split it into
>> several smaller trunks, each of them has been defined in a function as a
>> individual test group for several related testcases.

Thank you for the nice refactoring and reviews!

>> Using bash getopts function to parse command line arguments, and involk
> 
> One very minor thing, maybe Matthieu could fix "invoke" in the line 
> above when applying?

Done!

Applied in our Git repo with Mat's RvB tag and the commit message fix.

- 9e4a0d48d69c: selftests: mptcp: add command line arguments for 
mptcp_join.sh
- Results: 82d218ddd494..032c02a0c949

Tests + export are have been queued!

Cheers,
Matt
-- 
Tessares | Belgium | Hybrid Access Solutions
www.tessares.net