MPTCP Linux Development
 help / color / mirror / Atom feed
From: Matthieu Baerts <matttbe@kernel.org>
To: Sasha Levin <sashal@kernel.org>
Cc: Simon Horman <horms@kernel.org>,
	Kuniyuki Iwashima <kuniyu@google.com>,
	Jakub Kicinski <kuba@kernel.org>,
	stable@vger.kernel.org, Eric Dumazet <edumazet@google.com>,
	MPTCP Linux <mptcp@lists.linux.dev>
Subject: Re: [PATCH 6.12.y 8/8] mptcp: reset blackhole on success with non-loopback ifaces
Date: Mon, 20 Oct 2025 18:25:36 +0200	[thread overview]
Message-ID: <5b398571-0a1a-4d4e-a6f7-e091866443df@kernel.org> (raw)
In-Reply-To: <20251020154409.1823664-8-sashal@kernel.org>

Hi Sasha, Greg,

On 20/10/2025 17:44, Sasha Levin wrote:
> From: "Matthieu Baerts (NGI0)" <matttbe@kernel.org>
> 
> [ Upstream commit 833d4313bc1e9e194814917d23e8874d6b651649 ]

The backport of this whole series for v6.12, containing these commits...

- e7b9ecce562c ("tcp: convert to dev_net_rcu()")
- 15492700ac41 ("tcp: cache RTAX_QUICKACK metric in a hot cache line")
- 88fe14253e18 ("net: dst: add four helpers to annotate data-races
  around dst->dev")
- a74fc62eec15 ("ipv4: adopt dst_dev, skb_dst_dev and
  skb_dst_dev_net[_rcu]")
- 1dbf1d590d10 ("net: Add locking to protect skb->dev access in
  ip_output")
- 108a86c71c93 ("mptcp: Call dst_release() in mptcp_active_enable().")
- 893c49a78d9f ("mptcp: Use __sk_dst_get() and dst_dev_rcu() in
  mptcp_active_enable().")
- 833d4313bc1e ("mptcp: reset blackhole on success with non-loopback
  ifaces")

... looks good to me, if that's also OK for Eric and/or Kuniyuki.



Please note that these commits should also help to backport a few more
fixes from Kuniyuki from this series:

  https://lore.kernel.org/20250916214758.650211-1-kuniyu@google.com

- 3d3466878afd ("smc: Fix use-after-free in __pnet_find_base_ndev().")
- 935d783e5de9 ("smc: Use __sk_dst_get() and dst_dev_rcu() in in
  smc_clc_prfx_set().")
- 235f81045c00 ("smc: Use __sk_dst_get() and dst_dev_rcu() in
  smc_clc_prfx_match().")
- 0b0e4d51c655 ("smc: Use __sk_dst_get() and dst_dev_rcu() in
  smc_vlan_by_tcpsk().")
- c65f27b9c3be ("tls: Use __sk_dst_get() and dst_dev_rcu() in
  get_netdev_for_sock().")

And also eventually commit b62a59c18b69 ("tcp: use dst_dev_rcu() in
tcp_fastopen_active_disable_ofo_check()") from Eric.

(I don't know who will initiate these backports.)

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.


           reply	other threads:[~2025-10-20 16:25 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <20251020154409.1823664-8-sashal@kernel.org>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5b398571-0a1a-4d4e-a6f7-e091866443df@kernel.org \
    --to=matttbe@kernel.org \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=kuba@kernel.org \
    --cc=kuniyu@google.com \
    --cc=mptcp@lists.linux.dev \
    --cc=sashal@kernel.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox