Re: [PATCH 6.12.y 8/8] mptcp: reset blackhole on success with non-loopback ifaces

Re: [PATCH 6.12.y 8/8] mptcp: reset blackhole on success with non-loopback ifaces

[Matthieu Baerts]

Hi Sasha, Greg,

On 20/10/2025 17:44, Sasha Levin wrote:
> From: "Matthieu Baerts (NGI0)" <matttbe@kernel.org>
> 
> [ Upstream commit 833d4313bc1e9e194814917d23e8874d6b651649 ]

The backport of this whole series for v6.12, containing these commits...

- e7b9ecce562c ("tcp: convert to dev_net_rcu()")
- 15492700ac41 ("tcp: cache RTAX_QUICKACK metric in a hot cache line")
- 88fe14253e18 ("net: dst: add four helpers to annotate data-races
  around dst->dev")
- a74fc62eec15 ("ipv4: adopt dst_dev, skb_dst_dev and
  skb_dst_dev_net[_rcu]")
- 1dbf1d590d10 ("net: Add locking to protect skb->dev access in
  ip_output")
- 108a86c71c93 ("mptcp: Call dst_release() in mptcp_active_enable().")
- 893c49a78d9f ("mptcp: Use __sk_dst_get() and dst_dev_rcu() in
  mptcp_active_enable().")
- 833d4313bc1e ("mptcp: reset blackhole on success with non-loopback
  ifaces")

... looks good to me, if that's also OK for Eric and/or Kuniyuki.



Please note that these commits should also help to backport a few more
fixes from Kuniyuki from this series:

  https://lore.kernel.org/20250916214758.650211-1-kuniyu@google.com

- 3d3466878afd ("smc: Fix use-after-free in __pnet_find_base_ndev().")
- 935d783e5de9 ("smc: Use __sk_dst_get() and dst_dev_rcu() in in
  smc_clc_prfx_set().")
- 235f81045c00 ("smc: Use __sk_dst_get() and dst_dev_rcu() in
  smc_clc_prfx_match().")
- 0b0e4d51c655 ("smc: Use __sk_dst_get() and dst_dev_rcu() in
  smc_vlan_by_tcpsk().")
- c65f27b9c3be ("tls: Use __sk_dst_get() and dst_dev_rcu() in
  get_netdev_for_sock().")

And also eventually commit b62a59c18b69 ("tcp: use dst_dev_rcu() in
tcp_fastopen_active_disable_ofo_check()") from Eric.

(I don't know who will initiate these backports.)

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.