Re: [PATCH mptcp-next v14 00/14] dump for userspace pm

[Matthieu Baerts <matttbe@kernel.org>]

Hi Geliang, Mat,

On 20/02/2024 10:58 am, Geliang Tang wrote:
> From: Geliang Tang <tanggeliang@kylinos.cn>
> 
> v14:
>  - address Matt's comments in v13.
>  - I have to use these lines in patch #8:
> 
>       local cmd_ret=0
>       local out=$(${cmd} 2>${err}) || cmd_ret=${?}
> 
>    The following expected code breaks pm_netlink.sh, I don't know why:
> 
>       local out cmd_ret=0
>       out=$(${cmd} 2>${err}) || cmd_ret=${?}
> 
>    If this is still a problem, I'll send a squash-to patch to fix it.
> 
> Geliang Tang (14):
>   mptcp: export mptcp_genl_family & mptcp_nl_fill_addr
>   mptcp: implement mptcp_userspace_pm_dump_addr
>   mptcp: add token for get-addr in yaml
>   mptcp: dump addrs in userspace pm list
>   mptcp: check userspace pm flags
>   selftests: mptcp: add userspace pm subflow flag
>   selftests: mptcp: add token for dump_addr
>   selftests: mptcp: add mptcp_lib_check_output helper
>   selftests: mptcp: dump userspace addrs list
>   mptcp: add userspace_pm_lookup_addr_by_id helper
>   mptcp: implement mptcp_userspace_pm_get_addr
>   mptcp: get addr in userspace pm list
>   selftests: mptcp: add token for get_addr
>   selftests: mptcp: userspace pm get addr tests

Thank you for the new version and the reviews!

Now in our tree (feat. for next):

New patches for t/upstream:
- 7d868c62af9f: mptcp: export mptcp_genl_family & mptcp_nl_fill_addr
- 67cb691f1093: mptcp: implement mptcp_userspace_pm_dump_addr
- 60ef9f34e3d3: mptcp: add token for get-addr in yaml
- ffb2fe640112: mptcp: dump addrs in userspace pm list
- 76eac7d3c80c: mptcp: check userspace pm flags
- 409cea20942c: selftests: mptcp: add userspace pm subflow flag
- 6353432774ce: selftests: mptcp: add token for dump_addr
- d09f50cf57ae: selftests: mptcp: add mptcp_lib_check_output helper
- c6ad331dc5ab: selftests: mptcp: dump userspace addrs list
- 47038dcd3675: mptcp: add userspace_pm_lookup_addr_by_id helper
- 2a5b3503d500: mptcp: implement mptcp_userspace_pm_get_addr
- bbfcefc51c19: mptcp: get addr in userspace pm list
- 1cda2a037f12: selftests: mptcp: add token for get_addr
- d0c5cd880322: selftests: mptcp: userspace pm get addr tests
- Results: 23f1f4962d2e..bf8465c7dc96 (export)

- ae4144118862: "squashed" in "selftests: mptcp: add
mptcp_lib_check_output helper"
- Results: bf8465c7dc96..55a829ff16aa (export)

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.