Re: [PATCH mptcp-next v14 00/14] dump for userspace pm

[Mat Martineau <martineau@kernel.org>]

On Tue, 20 Feb 2024, Matthieu Baerts wrote:

> Hi Geliang, Mat,
>
> On 20/02/2024 12:50 pm, Matthieu Baerts wrote:
>> Hi Geliang,
>>
>> On 20/02/2024 10:58, Geliang Tang wrote:
>>> From: Geliang Tang <tanggeliang@kylinos.cn>
>>>
>>> v14:
>>>  - address Matt's comments in v13.
>>
>> Thank you for the new version!
>>
>> I didn't look at it yet, but:
>>
>>>  - I have to use these lines in patch #8:
>>>
>>>       local cmd_ret=0
>>>       local out=$(${cmd} 2>${err}) || cmd_ret=${?}
>>>
>>>    The following expected code breaks pm_netlink.sh, I don't know why:
>>>
>>>       local out cmd_ret=0
>>>       out=$(${cmd} 2>${err}) || cmd_ret=${?}
>>>
>>>    If this is still a problem, I'll send a squash-to patch to fix it.
>>
>> Yes, we should either fix warnings or explicitly mark the false positive
>> ones as ignored.
>>
>> Can you try with the attached patch please? It is not clear to me why
>> the second block doesn't do the same as the first one.
>>
>> I can squash it when applying the series if there are no other comments.
>
> There are no other comments from me, thanks for the v14.
>
> Reviewed-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
>
> @Geliang: OK for you if I squash the suggested patch?
>
> @Mat: still OK for you with this v14? There are only modifications in
> the selftests (patches 8, 9 and 14) except a small change in patch 5.
>

Yes, v14 looks good, my tag still applies:

Reviewed-by: Mat Martineau <martineau@kernel.org>

Thanks for your review Matthieu!


- Mat