Re: [PATCH mptcp-next v9 0/7] add mptcp_subflow bpf_iter

[Mat Martineau <martineau@kernel.org>]

On Wed, 9 Oct 2024, Geliang Tang wrote:

> From: Geliang Tang <tanggeliang@kylinos.cn>
>
> v9:
> - rename bpf prog to "mptcp_bpf_iters_subflow.c"
> - drop the helper bpf_mptcp_sk(), it's not used in this test.
>

Hi Geliang -

Series LGTM, thanks for all the updates.

Reviewed-by: Mat Martineau <martineau@kernel.org>

> v8:
> - Make the test prog in patch 4 more like a bpf packet scheduler.
> - Export more mptcp helpers into BPF in patch 1.
>
> v7:
> - As Martin recently replied, mptcp_stubflow bpf_iter can still be
> used in tracing. So go back to the tracing selftest.
>
> v6:
> - add KF_TRUSTED_ARGS flag in patch 2 (Andrii, Martin), then acquire
> and release helpers (patch 3) are needed to be implemented.
> - test mptcp_subflow bpf_iter in "cgroup/getsockopt" (patch 5),
> instead of testing them in "tracing" (Martin).
>
> v5:
> - update patch 1 as Andrii suggested: if msk is NULL, initialize
> kit->msk to NULL in _new() and check it in _next().
>
> v4:
> - squash patch 1/5 and 3/5 in v3 together as Matt suggested.
> - a new squash-to patch to drop mptcp_subflow_active declaration in
>   bpf_burst.
>
> v3:
> - drop bpf_iter__mptcp_subflow, __diag_push, __diag_pop and
> __diag_ignore_all
> - drop declarations for bpf kfuncs
>
> v2:
> - update patch 1 as Martin and Andrii suggested.
> - fix warnings and errors reported by MPTCP CI.
>
> This patch set adds a mptcp_subflow type bpf_iter, and self tests.
>
> Geliang Tang (7):
>  bpf: Register mptcp common kfunc set
>  bpf: Add mptcp_subflow bpf_iter
>  bpf: Add mptcp_sock acquire and release helpers
>  selftests/bpf: Add mptcp_subflow bpf_iter test prog
>  selftests/bpf: More endpoints for endpoint_init
>  Squash to "selftests/bpf: Add bpf scheduler test"
>  selftests/bpf: Add mptcp_subflow bpf_iter subtest
>
> net/mptcp/bpf.c                               |  95 ++++++++++++-
> .../testing/selftests/bpf/bpf_experimental.h  |   7 +
> .../testing/selftests/bpf/prog_tests/mptcp.c  | 126 +++++++++++++++++-
> tools/testing/selftests/bpf/progs/mptcp_bpf.h |   9 ++
> .../bpf/progs/mptcp_bpf_iters_subflow.c       |  42 ++++++
> 5 files changed, 267 insertions(+), 12 deletions(-)
> create mode 100644 tools/testing/selftests/bpf/progs/mptcp_bpf_iters_subflow.c
>
> -- 
> 2.43.0
>
>
>