Re: [PATCH mptcp-next v9 0/7] add mptcp_subflow bpf_iter

[Matthieu Baerts <matttbe@kernel.org>]

Hi Geliang,

On 09/10/2024 12:05, MPTCP CI wrote:
> Hi Geliang,
> 
> Thank you for your modifications, that's great!
> 
> But sadly, our CI spotted some issues with it when trying to build it.
> 
> You can find more details there:
> 
>   https://github.com/multipath-tcp/mptcp_net-next/actions/runs/11252652867

I was looking at applying this series, but there are some issues
reported by the CI:

  warning: symbol 'bpf_*mptcp_*' was not declared. Should it be static?

Could it be possible to have a fix for that please before applying the
series?

I guess you are missing __bpf_kfunc_start_defs() and
__bpf_kfunc_end_defs() around the declaration of the BPF dedicated
kfunc, no?


Also, where should I apply these patches? Before "mptcp: add sched_data
helpers"? But then there should not be any dependences on the BPF
scheduler work (and I think that would be better without this
dependence, see my comment on patch 4/7)

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.