Re: [RFC mptcp-next v22 18/20] selftests: tls: set timeout for multi_chunk_sendfile

[Paolo Abeni <pabeni@redhat.com>]

On 5/29/26 1:14 PM, Geliang Tang wrote:
> From: Geliang Tang <tanggeliang@kylinos.cn>
> 
> The multi_chunk_sendfile test can time out with the default 30-second
> limit when run on certain configurations (e.g., MPTCP). Add a 240-second
> timeout using TEST_F_TIMEOUT to prevent failure:
> 
>  # multi_chunk_sendfile: Test terminated by timeout 30
>  #          FAIL  tls.13_chacha_mptcp.multi_chunk_sendfile
>  not ok 204 tls.13_chacha_mptcp.multi_chunk_sendfile
> 
> Suggested-by: Paolo Abeni <pabeni@redhat.com>
> Co-developed-by: Gang Yan <yangang@kylinos.cn>
> Signed-off-by: Gang Yan <yangang@kylinos.cn>
> Signed-off-by: Geliang Tang <tanggeliang@kylinos.cn>
> ---
>  tools/testing/selftests/net/tls.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/net/tls.c b/tools/testing/selftests/net/tls.c
> index 4ae7505846f9..6f51da27ef1e 100644
> --- a/tools/testing/selftests/net/tls.c
> +++ b/tools/testing/selftests/net/tls.c
> @@ -536,7 +536,7 @@ static void chunked_sendfile(struct __test_metadata *_metadata,
>  	close(fd);
>  }
>  
> -TEST_F(tls, multi_chunk_sendfile)
> +TEST_F_TIMEOUT(tls, multi_chunk_sendfile, 240)
>  {
>  	chunked_sendfile(_metadata, self, 4096, 4096);
>  	chunked_sendfile(_metadata, self, 4096, 0);

Is this still required? in my tests since v8 of the stall patch I could
not observe any long timeout anymore.

/P