MPTCP Linux Development
 help / color / mirror / Atom feed
From: Geliang Tang <geliang@kernel.org>
To: Paolo Abeni <pabeni@redhat.com>, mptcp@lists.linux.dev
Cc: Geliang Tang <tanggeliang@kylinos.cn>, Gang Yan <yangang@kylinos.cn>
Subject: Re: [RFC mptcp-next v22 18/20] selftests: tls: set timeout for multi_chunk_sendfile
Date: Sat, 30 May 2026 12:25:42 +0800	[thread overview]
Message-ID: <dccefbdd5d01b06263dca52a4197a575181803e6.camel@kernel.org> (raw)
In-Reply-To: <abaf1bd3-58fa-4161-a1c0-18bebf4608ae@redhat.com>

Hi Paolo,

On Fri, 2026-05-29 at 17:00 +0200, Paolo Abeni wrote:
> On 5/29/26 1:14 PM, Geliang Tang wrote:
> > From: Geliang Tang <tanggeliang@kylinos.cn>
> > 
> > The multi_chunk_sendfile test can time out with the default 30-
> > second
> > limit when run on certain configurations (e.g., MPTCP). Add a 240-
> > second
> > timeout using TEST_F_TIMEOUT to prevent failure:
> > 
> >  # multi_chunk_sendfile: Test terminated by timeout 30
> >  #          FAIL  tls.13_chacha_mptcp.multi_chunk_sendfile
> >  not ok 204 tls.13_chacha_mptcp.multi_chunk_sendfile
> > 
> > Suggested-by: Paolo Abeni <pabeni@redhat.com>
> > Co-developed-by: Gang Yan <yangang@kylinos.cn>
> > Signed-off-by: Gang Yan <yangang@kylinos.cn>
> > Signed-off-by: Geliang Tang <tanggeliang@kylinos.cn>
> > ---
> >  tools/testing/selftests/net/tls.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/tools/testing/selftests/net/tls.c
> > b/tools/testing/selftests/net/tls.c
> > index 4ae7505846f9..6f51da27ef1e 100644
> > --- a/tools/testing/selftests/net/tls.c
> > +++ b/tools/testing/selftests/net/tls.c
> > @@ -536,7 +536,7 @@ static void chunked_sendfile(struct
> > __test_metadata *_metadata,
> >  	close(fd);
> >  }
> >  
> > -TEST_F(tls, multi_chunk_sendfile)
> > +TEST_F_TIMEOUT(tls, multi_chunk_sendfile, 240)
> >  {
> >  	chunked_sendfile(_metadata, self, 4096, 4096);
> >  	chunked_sendfile(_metadata, self, 4096, 0);
> 
> Is this still required? in my tests since v8 of the stall patch I
> could
> not observe any long timeout anymore.

Thank you for the reminder. I will double-check.

-Geliang

> 
> /P

  reply	other threads:[~2026-05-30  4:25 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-29 11:13 [RFC mptcp-next v22 00/20] MPTCP KTLS support Geliang Tang
2026-05-29 11:13 ` [RFC mptcp-next v22 01/20] tls: add clone callback to prevent NULL accept crash Geliang Tang
2026-05-29 11:13 ` [RFC mptcp-next v22 02/20] tls: init mixed SW/TOE proto to prevent NULL call Geliang Tang
2026-05-29 11:13 ` [RFC mptcp-next v22 03/20] tls: add ESTABLISHED state check for TOE bypass Geliang Tang
2026-05-29 11:13 ` [RFC mptcp-next v22 04/20] tcp: add socket lock to TCP_ULP getsockopt Geliang Tang
2026-05-29 11:13 ` [RFC mptcp-next v22 05/20] tls: add per-protocol cache for MPTCP support Geliang Tang
2026-05-29 11:13 ` [RFC mptcp-next v22 06/20] tls: introduce tls protocol ops structure Geliang Tang
2026-05-29 11:13 ` [RFC mptcp-next v22 07/20] tls: store protocol ops pointer in tls_proto Geliang Tang
2026-05-29 11:13 ` [RFC mptcp-next v22 08/20] mptcp: update mptcp_check_readable helper Geliang Tang
2026-05-29 11:13 ` [RFC mptcp-next v22 09/20] mptcp: implement mptcp-specific tls protocol ops Geliang Tang
2026-05-29 11:13 ` [RFC mptcp-next v22 10/20] tls: disable device offload for mptcp sockets Geliang Tang
2026-05-29 11:13 ` [RFC mptcp-next v22 11/20] mptcp: update ulp getsockopt for tls support Geliang Tang
2026-05-29 11:13 ` [RFC mptcp-next v22 12/20] mptcp: enable ulp setsockopt " Geliang Tang
2026-05-29 11:13 ` [RFC mptcp-next v22 13/20] selftests: mptcp: connect: use espintcp for ulp test Geliang Tang
2026-05-29 11:13 ` [RFC mptcp-next v22 14/20] selftests: tls: add mptcp variant for testing Geliang Tang
2026-05-29 11:13 ` [RFC mptcp-next v22 15/20] selftests: tls: increase pollin timeouts for mptcp Geliang Tang
2026-05-29 11:13 ` [RFC mptcp-next v22 16/20] selftests: tls: increase nonblocking data size " Geliang Tang
2026-05-29 11:13 ` [RFC mptcp-next v22 17/20] selftests: tls: retry bind on EINVAL in shutdown_reuse Geliang Tang
2026-05-29 11:14 ` [RFC mptcp-next v22 18/20] selftests: tls: set timeout for multi_chunk_sendfile Geliang Tang
2026-05-29 15:00   ` Paolo Abeni
2026-05-30  4:25     ` Geliang Tang [this message]
2026-05-31  1:57       ` Geliang Tang
2026-05-29 11:14 ` [RFC mptcp-next v22 19/20] selftests: tls: add mptcp test cases Geliang Tang
2026-05-29 11:14 ` [RFC mptcp-next v22 20/20] selftests: mptcp: cover mptcp tls tests Geliang Tang
2026-05-29 12:46 ` [RFC mptcp-next v22 00/20] MPTCP KTLS support MPTCP CI

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=dccefbdd5d01b06263dca52a4197a575181803e6.camel@kernel.org \
    --to=geliang@kernel.org \
    --cc=mptcp@lists.linux.dev \
    --cc=pabeni@redhat.com \
    --cc=tanggeliang@kylinos.cn \
    --cc=yangang@kylinos.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox