Re: [PATCH mptcp-next 2/2] selftests: mptcp: convert iptables to nftables for mptcp_join.sh

[Hangbin Liu <hangbin.liu@linux.dev>]

On Thu, Sep 03, 2026 at 11:28:28AM +0200, Matthieu Baerts wrote:
> Hi Hangbin,
> 
> On 03/09/2026 04:02, Hangbin Liu wrote:
> > Hi Matthieu,
> > 
> > Sorry, My mbsync has some delays and I post v2 too quick before catching
> > your feedback.
> 
> No problem.
> 
> Just in case, maybe korgalore can help?
> 
> https://people.kernel.org/monsieuricon/tracking-kernel-development-with-korgalore

Thanks, learned a new tool.

> >> If you don't need this one (or any set in helpers), don't set it/them,
> >> and don't use a global variable. Or reset it in init_partial, but prefer
> >> using local variable with a limited scope.
> > 
> > Yes, we don't need the handle in other place, which I will remove them.
> > But for endpoint_tests(), after adding rules in reset_with_tcp_filter,
> > we need to remove the rule outside. I will reset it after each test.
> 
> Perhaps you could flush the whole table instead? But if it makes more
> sense to assign this variable, fine by me.

Yes, if not in purpose, I feel flush the whole table is dangerous.
Some rules may still in using in later testing.

> > Thanks for the notes. I used to rely on `b4 auto-to-cc` too much...
> 
> Most of the time, that's fine. It's just for some subsubtrees where
> (urgent & simple) fixes can go to the parent tree (netdev here)
> directly, but the rest can go only to the subsubtree ML.
> 
> BTW, if you are on top of our export(-net) (or for-review(-net)) branch,
> there is a .b4-config: you just need to use 'b4 send' then :)

Thanks. I am working on top of the export branch. I ran into a small issue
while using b4. The export branch is not fast‑forwardable. I used
`git reset --hard` to fall back to the top merge commit, then ran
`git pull` to fetch the latest changes.

However, I cannot perform a reset on the b4 branch, and git rebase also failed.
These steps have blocked me a little. I have to manually recreate the b4 branch,
or perhaps avoid using b4 when working on mptcp changes.

> 
> > An example of `nft -j` output:
> 
> Thanks for the output!

I have post the new version, which use jq to get the handle now.

Thanks
Hangbin