Re: [PATCH mptcp-net 1/4] mptcp: drop the push_pending field

[Matthieu Baerts <matttbe@kernel.org>]

Hi Paolo,

On 08/02/2024 16:12, Paolo Abeni wrote:
> On Thu, 2024-02-08 at 12:36 +0100, Matthieu Baerts wrote:
>> Hi Paolo,
>>
>> On 15/01/2024 16:16, Paolo Abeni wrote:
>>> Such field is there to avoid acquiring the data lock in a few spots,
>>> but if adds complexity to the already non trivial locking schema.
>>>
>>> All the relevant call sites (mptcp-level reinjection, set socket optins),
>>> are slow-path, drop such field in favor of 'cb_flags', adding the relevant
>>> locking.
>>
>> In your cover-letter, you mentioned:
>>
>>> Patch 1 has no fixes, but still is logically tied to the other patches.
>>
>> I think it makes sense to have this patch in -net, especially because it
>> is logically tied to the others. Would it be OK for you if I add:
>>
>>   Fixes: e9d09baca676 ("mptcp: avoid atomic bit manipulation when possible")
> 
> The obove, or add a sentence to the commit message alike:
> 
> """
> This will also simplify the next patch
> """

Good idea! I added both:

> This patch could be seen as an improvement, instead of a fix. But it
> simplifies the next patch. The 'Fixes' tag has been added to help having
> this series backported to stable.

I hope that's OK! :)

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.