Re: [PATCH mptcp-net 0/4] mptcp: locking cleanup

[Mat Martineau <martineau@kernel.org>]

On Mon, 15 Jan 2024, Paolo Abeni wrote:

> This is a preparatory work for the TCP_NOTSENT_LOWAT support. The latter
> will need tracking more state under the msk data lock.
>
> Since the locking msk locking schema is already quite complex, do a long
> awaited clean-up step, moving several confusing lockless initialization
> under the relevant locks.
>
> Note that patches 2-4 carry fixes tag, and could target the net tree,
> but AFACIS no real race could really happen even prior to such patches
> as the MPTCP-level state machine implicitly ensure proper serialization
> of the write accesses, even lacking explicit lock.
>
> Patch 1 has no fixes, but still is logically tied to the other patches.
> Possibly we could target net-next for the whole series.
>
> Paolo Abeni (4):
>  mptcp: drop the push_pending field
>  mptcp: fix rcv space initialization
>  mptcp: fix more tx path fields initialization
>  mptcp: corner case locking for rx path fields initialization
>

Hi Paolo -

The series LGTM, assuming the CI failure is the issue fixed by "mptcp: 
relax check on MPC passive fallback":

Reviewed-by: Mat Martineau <martineau@kernel.org>

> net/mptcp/fastopen.c |  6 ++--
> net/mptcp/options.c  |  9 +++---
> net/mptcp/protocol.c | 31 ++++++++++---------
> net/mptcp/protocol.h | 13 ++++----
> net/mptcp/subflow.c  | 71 +++++++++++++++++++++++++++-----------------
> 5 files changed, 75 insertions(+), 55 deletions(-)
>
> -- 
> 2.43.0
>
>
>