MPTCP Linux Development
 help / color / mirror / Atom feed
From: Matthieu Baerts <matttbe@kernel.org>
To: Geliang Tang <geliang@kernel.org>
Cc: mptcp@lists.linux.dev, Geliang Tang <tanggeliang@kylinos.cn>
Subject: Re: [PATCH mptcp-next] Squash to "selftests: mptcp: move stats info in case of errors to lib.sh"
Date: Fri, 10 Jan 2025 08:41:45 +0100 (GMT+01:00)	[thread overview]
Message-ID: <b6165440-f421-42a7-bc8d-e8e8bcaeb69a@kernel.org> (raw)
In-Reply-To: <ff9a10bb4359ec77fc0b7499f44b388d737abe0f.1736477907.git.tanggeliang@kylinos.cn>

Hi Geliang,

10 Jan 2025 04:02:53 Geliang Tang <geliang@kernel.org>:

> Drop the last two arguments "lstat" and "cstat" of mptcp_lib_pr_err_stats.

I think it might be better to keep these arguments, not to have the lib assuming the files will be located there, e.g. just in case we move them elsewhere later, to be clear that when reading the code in the tests that these files will be used there, etc. no?

Cheers,
Matt

  parent reply	other threads:[~2025-01-10  7:41 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-10  3:02 [PATCH mptcp-next] selftests: mptcp: sockopt: save nstat infos Geliang Tang
2025-01-10  3:02 ` [PATCH mptcp-next] Squash to "selftests: mptcp: move stats info in case of errors to lib.sh" Geliang Tang
2025-01-10  4:10   ` MPTCP CI
2025-01-10  7:41   ` Matthieu Baerts [this message]
2025-01-10 10:57     ` Matthieu Baerts
2025-01-10  4:13 ` [PATCH mptcp-next] selftests: mptcp: sockopt: save nstat infos MPTCP CI
2025-01-10 10:49 ` Matthieu Baerts

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b6165440-f421-42a7-bc8d-e8e8bcaeb69a@kernel.org \
    --to=matttbe@kernel.org \
    --cc=geliang@kernel.org \
    --cc=mptcp@lists.linux.dev \
    --cc=tanggeliang@kylinos.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox