From: Matthieu Baerts <matttbe@kernel.org>
To: Geliang Tang <geliang@kernel.org>, mptcp@lists.linux.dev
Cc: Geliang Tang <tanggeliang@kylinos.cn>
Subject: Re: [PATCH mptcp-next] selftests: mptcp: sockopt: save nstat infos
Date: Fri, 10 Jan 2025 11:49:11 +0100 [thread overview]
Message-ID: <ec4dff48-96c1-4aa1-9a46-6560ac6587e4@kernel.org> (raw)
In-Reply-To: <5ff48cd1eed9a8b4c51a9ba5d7f9e0d0e8b0389b.1736477880.git.tanggeliang@kylinos.cn>
Hi Geliang,
On 10/01/2025 04:02, Geliang Tang wrote:
> From: Geliang Tang <tanggeliang@kylinos.cn>
>
> Similar to the way nstat information is stored in mptcp_connect.sh
> and mptcp_join.sh scripts, this patch adds a similar way for
> mptcp_sockopt.sh and displays the nstat information when errors
> occur.
Thank you for the patch! Even if I'm not sure if it will really help
debugging issues, at least it is uniformed, and it looks good to me:
Reviewed-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
> Please apply this patch before the commit
>
> "selftests: mptcp: simult_flows: unify errors msgs"
>
> when merging it.
Will do! Or after, it might be easier with the automated scripts.
Can I add your Reviewed-by tag on my other patches from this series?
Cheers,
Matt
--
Sponsored by the NGI0 Core fund.
prev parent reply other threads:[~2025-01-10 10:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-10 3:02 [PATCH mptcp-next] selftests: mptcp: sockopt: save nstat infos Geliang Tang
2025-01-10 3:02 ` [PATCH mptcp-next] Squash to "selftests: mptcp: move stats info in case of errors to lib.sh" Geliang Tang
2025-01-10 4:10 ` MPTCP CI
2025-01-10 7:41 ` Matthieu Baerts
2025-01-10 10:57 ` Matthieu Baerts
2025-01-10 4:13 ` [PATCH mptcp-next] selftests: mptcp: sockopt: save nstat infos MPTCP CI
2025-01-10 10:49 ` Matthieu Baerts [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ec4dff48-96c1-4aa1-9a46-6560ac6587e4@kernel.org \
--to=matttbe@kernel.org \
--cc=geliang@kernel.org \
--cc=mptcp@lists.linux.dev \
--cc=tanggeliang@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox